You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by ro...@apache.org on 2011/12/09 20:33:07 UTC

svn commit: r1212593 - /thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc

Author: roger
Date: Fri Dec  9 19:33:07 2011
New Revision: 1212593

URL: http://svn.apache.org/viewvc?rev=1212593&view=rev
Log:
THRIFT-1452 generate a swap() method for all generated structs

fix compiler warnings, when having empty structs

Modified:
    thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc

Modified: thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc
URL: http://svn.apache.org/viewvc/thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc?rev=1212593&r1=1212592&r2=1212593&view=diff
==============================================================================
--- thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc (original)
+++ thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc Fri Dec  9 19:33:07 2011
@@ -1526,6 +1526,14 @@ void t_cpp_generator::generate_struct_sw
       indent() << "swap(a.__isset, b.__isset);" << endl;
   }
 
+  // handle empty structs
+  if (fields.size() == 0) {
+    out <<
+      indent() << "(void) a;" << endl;
+    out <<
+      indent() << "(void) b;" << endl;
+  }
+
   scope_down(out);
   out << endl;
 }