You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/09 07:41:13 UTC

[GitHub] [incubator-mxnet] samskalicky opened a new pull request #19103: [WIP] improve createOpState for custom ops

samskalicky opened a new pull request #19103:
URL: https://github.com/apache/incubator-mxnet/pull/19103


   ## Description ##
   Support passing all args from createOpState to custom ops: context, input shapes & types
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] samskalicky merged pull request #19103: Improve createOpState for custom ops

Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #19103:
URL: https://github.com/apache/incubator-mxnet/pull/19103






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] samskalicky merged pull request #19103: Improve createOpState for custom ops

Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #19103:
URL: https://github.com/apache/incubator-mxnet/pull/19103


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19103: [WIP] improve createOpState for custom ops

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19103:
URL: https://github.com/apache/incubator-mxnet/pull/19103#issuecomment-689371071


   Hey @samskalicky , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-gpu, miscellaneous, edge, sanity, windows-gpu, unix-cpu, centos-gpu, clang, centos-cpu, windows-cpu, website]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] rondogency commented on pull request #19103: Improve createOpState for custom ops

Posted by GitBox <gi...@apache.org>.
rondogency commented on pull request #19103:
URL: https://github.com/apache/incubator-mxnet/pull/19103#issuecomment-690709209


   One quick request, in terms of the test, can you add an end-to-end test training example written in gluon like this one: https://github.com/apache/incubator-mxnet/pull/18167, so that we can have better test suite on performance to show to user


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] samskalicky commented on pull request #19103: Improve createOpState for custom ops

Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19103:
URL: https://github.com/apache/incubator-mxnet/pull/19103#issuecomment-690022320


   I think so, with this PR the examples are all up to date now with Gluon (having removed the symbol bind/executor stuff). 
   
   As with anything, as it gets more use we'll find ways to improve things. But we're ready to start helping users extend MXNet!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19103: Improve createOpState for custom ops

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19103:
URL: https://github.com/apache/incubator-mxnet/pull/19103#issuecomment-690018117


   thanks for the enhancement! as we are approaching the (beta) release of mxnet, do you think the API would be finalized with this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] samskalicky merged pull request #19103: Improve createOpState for custom ops

Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #19103:
URL: https://github.com/apache/incubator-mxnet/pull/19103


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] samskalicky commented on pull request #19103: [WIP] improve createOpState for custom ops

Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19103:
URL: https://github.com/apache/incubator-mxnet/pull/19103#issuecomment-690013327


   @mseth10 @rondogency this is a small PR with just the change for custom stateful ops. Please review, thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] samskalicky merged pull request #19103: Improve createOpState for custom ops

Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #19103:
URL: https://github.com/apache/incubator-mxnet/pull/19103


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org