[GitHub] [helix] lei-xia commented on a change in pull request #601: Add new constructors and close() to Helix API

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #601: Add new constructors and close() to Helix API
URL: https://github.com/apache/helix/pull/601#discussion_r345976527
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/ZkHelixClusterVerifier.java
 ##########
 @@ -48,6 +48,10 @@
   protected static int DEFAULT_PERIOD = 500;
 
   protected final HelixZkClient _zkClient;
+  // true if ZkHelixClusterVerifier was instantiated with a HelixZkClient, false otherwise
+  // This is used for close() to determine how ZkHelixClusterVerifier should close the underlying
+  // ZkClient
+  private boolean _usesExternalZkClient;
 
 Review comment:
   this can be  final too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org