[GitHub] [incubator-brpc] chenzhangyi commented on issue #733: Add a gflag to enable tcp keepalive

[GitBox <gi...@apache.org>]

chenzhangyi commented on issue #733: Add a gflag to enable tcp keepalive
URL: https://github.com/apache/incubator-brpc/pull/733#issuecomment-485221553
 
 
   @lingbin 
   As far as I know, braft has resolved this problem by issuing `heartbeats` from `leaders` to `followers` periodically. 
   In your case, writing something to the semi connection would trigger RTO(if the server side doesn't receive the package) or RST(if the server side receives the package) and the client side would finally close the connection.
   It might lead to a performance issue if adding the `tcp keepalive` flag to a large amount of connections. It's better to do a benchmark test to find out the overhead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org