You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2025/07/25 20:19:45 UTC

[PR] TLS group name: handle SSL resumption [trafficserver]

bneradt opened a new pull request, #12393:
URL: https://github.com/apache/trafficserver/pull/12393

   This is an increment on top of: #12261
   
   This properly handles retrieval of the TLS group name in the cases of TLS resumption. TLS group naming is used in the cqssg log field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TLS group name: handle SSL resumption [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12393:
URL: https://github.com/apache/trafficserver/pull/12393#issuecomment-3128272443

   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TLS curve/group name logging for Ticket Resumption [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #12393:
URL: https://github.com/apache/trafficserver/pull/12393#issuecomment-3130211363

   It doesn't seem like we need to add a new variable to record a group name. Although both OpenSSL and BoringSSL have different APIs for curve and group, the getters are actually just aliases unlike the setters. We should be able to use the same variable for both curve and group.
   
   `TLSBasicSupport::get_tls_group` which was added by https://github.com/apache/trafficserver/pull/12261 is probably unnecessary. I don't know why the previous code doesn't work for group, but the function to get curve/group id is identical.
   ```
   $ git grep SSL_get_shared_curve include/
   include/openssl/ssl.h.in:# define SSL_get_shared_curve          SSL_get_shared_group
   ```
   
   Also, `SSL_get0_group_name` is only available on OpenSSL 3.2 or later. I see the `ifdef` and `get_tls_group` probably returns `nullptr` on OpenSSL 3.0, but I'd be surprised if there's no way to achieve it on 3.0.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TLS curve/group name logging for Ticket Resumption [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12393:
URL: https://github.com/apache/trafficserver/pull/12393#issuecomment-3134036901

   
   > Also, `SSL_get0_group_name` is only available on OpenSSL 3.2 or later. I see the `ifdef` and `get_tls_group` probably returns `nullptr` on OpenSSL 3.0, but I'd be surprised if there's no way to achieve it on 3.0.
   
   This is a great point. I updated the patch for openssl 3.0 and 3.1 via SSL_get_negotiated_group. Since 3.2, the docs say to prefer the new SSL_get0_group_name, but for 3.0 and 3.1 we can use the former. See:
   
   ```cpp
   #elif HAVE_SSL_GET_NEGOTIATED_GROUP                    // OpenSSL 3.0/3.1
     int group_nid = SSL_get_negotiated_group(ssl);
     if (group_nid != NID_undef) {
       char const *group_name = OBJ_nid2sn(group_nid);
       return group_name != nullptr ? std::string_view(group_name) : "";
     }
     return "";
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TLS curve/group name logging for Ticket Resumption [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12393:
URL: https://github.com/apache/trafficserver/pull/12393#issuecomment-3128928427

   [approve ci autest 2]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TLS curve/group name logging for Ticket Resumption [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12393:
URL: https://github.com/apache/trafficserver/pull/12393#issuecomment-3134122714

   [approve ci autest 2]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TLS curve/group name logging for Ticket Resumption [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #12393:
URL: https://github.com/apache/trafficserver/pull/12393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org