[GitHub] [spark] JoshRosen commented on pull request #36885: [SPARK-39489][CORE] Improve event logging JsonProtocol performance by using Jackson instead of Json4s

["JoshRosen (via GitHub)" <gi...@apache.org>]

JoshRosen commented on PR #36885:
URL: https://github.com/apache/spark/pull/36885#issuecomment-1426559525

   @dongjoon-hyun, thanks for the ping. I think that I spot the problem: it looks like the `File Name` field could contain a `null` value and the old code was likely handling JNothing -> `null.asInstanceOf[String]` implicitly.
   
   I think we can fix this by either modifying `extractString` to handle this case or by special-casing this for `FileName`. I'd prefer the former approach because it's probably more robust.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org