[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2202: [KYUUBI #2201] Show ExecutionId when running status on query engine page

[GitBox <gi...@apache.org>]

ulysses-you commented on code in PR #2202:
URL: https://github.com/apache/incubator-kyuubi/pull/2202#discussion_r853659889


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala:
##########
@@ -158,4 +156,19 @@ class ExecuteStatement(
     EventBus.post(
       SparkOperationEvent(this, operationListener.getExecutionId))
   }
+
+  def setCompiledStateIfNeeded(): Unit = synchronized {
+    if (getStatus.state == OperationState.RUNNING) {
+      super.setState(OperationState.COMPILED)

Review Comment:
   sorry, we should do `lastAccessTime = lastAccessTime + compiledTime` first, then `super.setState(OperationState.COMPILED)`.
   
   So we can move this to line170



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org