You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ro...@apache.org on 2007/08/26 17:49:38 UTC

svn commit: r569828 - in /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http: HeaderElement.java message/BasicHeaderElement.java

Author: rolandw
Date: Sun Aug 26 08:49:38 2007
New Revision: 569828

URL: http://svn.apache.org/viewvc?rev=569828&view=rev
Log:
added HeaderElement parameter accessors that do not require a temporary array

Modified:
    jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/HeaderElement.java
    jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicHeaderElement.java

Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/HeaderElement.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/HeaderElement.java?rev=569828&r1=569827&r2=569828&view=diff
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/HeaderElement.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/HeaderElement.java Sun Aug 26 08:49:38 2007
@@ -51,6 +51,9 @@
     NameValuePair[] getParameters();
     
     NameValuePair getParameterByName(String name);
-    
+
+    int getParameterCount();
+
+    NameValuePair getParameter(int index);
 }
 

Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicHeaderElement.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicHeaderElement.java?rev=569828&r1=569827&r2=569828&view=diff
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicHeaderElement.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicHeaderElement.java Sun Aug 26 08:49:38 2007
@@ -163,12 +163,38 @@
 
     /**
      * Get parameters, if any.
+     * The returned array is created for each invocation and can
+     * be modified by the caller without affecting this header element.
      *
      * @return parameters as an array of {@link NameValuePair}s
      */
     public NameValuePair[] getParameters() {
         return (NameValuePair[])this.parameters.clone();
     }
+
+
+    /**
+     * Obtains the number of parameters.
+     *
+     * @return  the number of parameters
+     */
+    public int getParameterCount() {
+        return this.parameters.length;
+    }
+
+
+    /**
+     * Obtains the parameter with the given index.
+     *
+     * @param index     the index of the parameter, 0-based
+     *
+     * @return  the parameter with the given index
+     */
+    public NameValuePair getParameter(int index) {
+        // ArrayIndexOutOfBoundsException is appropriate
+        return this.parameters[index];
+    }
+
 
     // --------------------------------------------------------- Public Methods