You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2005/07/09 10:50:43 UTC
2.0.6-dev [docs preview]
If anyone wants to preview the docs for 2.0.6-dev, you can see them here:
http://libapreq2.p6m7g8.net/
please use the offical site once 2.0.6-dev is released
http://httpd.apache.org/apreq/docs/libapreq2/
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Re: 2.06-dev-rc2 (was Re: 2.0.6-dev [docs preview])
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Wed, 13 Jul 2005, Philip M. Gollucci wrote:
> Randy Kobes wrote:
> > Any chance of using cp of ExtUtils::Command, to be
> > even more portable?
>
> While a good idea and more portable, I don't think so
> because you don't neccessarily have to have perl
> installed. You could be building without the PERL glue
> code.
Sorry about that - I must have misread the context of the
patch, as I thought it was in the same section as the
pod2html stuff, which would mean perl was available.
--
best regards,
randy
Re: 2.06-dev-rc2 (was Re: 2.0.6-dev [docs preview])
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Randy Kobes wrote:
> Any chance of using cp of ExtUtils::Command, to be
> even more portable?
While a good idea and more portable, I don't think so because you don't
neccessarily have to have perl installed. You could be building without
the PERL glue code.
The most portable way would be to use mkinstalldirs and a bsd install
script to copy things into place file/directory at a time ?
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Re: 2.06-dev-rc2 (was Re: 2.0.6-dev [docs preview])
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Wed, 13 Jul 2005, Philip M. Gollucci wrote:
> With the attached patch
> gmake docs docs_install
> actually make it all the way through.
>
> Note the addition of feather.gif (attached)
>
> It does:
> Replace cp -a with cp -R b/c cp -a is not portable,
[ .. ]
Any chance of using cp of ExtUtils::Command, to be
even more portable?
--
best regards,
randy
2.0.6-rc-2 docs preview #2
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
I've rebuilt the docs for preview again.
The APR::* modules are in it as fortold! Good work Joe!
[Note: this is with my previous 2 doc patches]
http://libapreq2.p6m7g8.net
HTH
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Re: 2.06-dev-rc2 (was Re: 2.0.6-dev [docs preview])
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Philip M. Gollucci wrote:
> Philip M. Gollucci wrote:
>
>> Philip M. Gollucci wrote:
>>
>>>
>>>> Cool. I just posted rc2 in the usual place
>>>>
>>>> http://people.apache.org/~joes/libapreq2-2.06-dev.rc2.tar.gz
> Next up, I'll try to fix some of the 10million warnings during the
> genration of docs.
>
With the attached patch, all the remaining doxygen warnings/errors come
from externally used projects or "not documented" (I take it we should
fix those). For reference a list of these is below the patch. I'll
look at documenting them later in the week. This patch(also attached)
fixes the following errors/warnings:
/usr/local/dev/repos/ASF/httpd/apreq/trunk/CHANGES:2: Warning: Found
unknown command `\brief'
/usr/local/dev/repos/ASF/httpd/apreq/trunk/CHANGES:366: Warning: End of
list marker found has invalid indent level
/usr/local/dev/repos/ASF/httpd/apreq/trunk/include/apreq_module.h:421:Warning:
argument `key' of command @param is not found in the argument list of
apreq_cookie(req, name)
svn diff
Index: CHANGES
===================================================================
--- CHANGES (revision 216120)
+++ CHANGES (working copy)
@@ -1,5 +1,5 @@
/** @page apreq_changes CHANGES
-@brief List of major changes.
+//! brief List of major changes.
@section v2_06 Changes with libapreq2-2.06
@@ -362,7 +362,7 @@
apreq_jar_t and added args_status field to apreq_request_t. Parsers
also must return their public status code when a NULL brigade is passed.
apreq_hook_disable_uploads() is also added.
- .
+
This is an ABI change affecting all versions of libapreq2 prior to
2.0.12.
- Perl API [joes]
Index: /usr/local/dev/repos/ASF/httpd/apreq/trunk/include/apreq_module.h
===================================================================
--- /usr/local/dev/repos/ASF/httpd/apreq/trunk/include/apreq_module.h
(revision 216120)
+++ /usr/local/dev/repos/ASF/httpd/apreq/trunk/include/apreq_module.h
(working copy)
@@ -423,7 +423,7 @@
* The match is case-insensitive.
*
* @param req request handle.
- * @param key desired cookie name
+ * @param name desired cookie name
*
* @return The first matching parameter (with args searched first) or
NULL.
*/
/include/apreq.h:41: Warning: Member APREQ_DECLARE_NONSTD(d) of file
apreq.h is not documented.
/include/apreq.h:42: Warning: Member APREQ_DECLARE_DATA of file apreq.h
is not documented.
/include/apreq.h:49: Warning: Member APREQ_DEFAULT_READ_BLOCK_SIZE of
file apreq.h is not documented.
/include/apreq.h:50: Warning: Member APREQ_DEFAULT_READ_LIMIT of file
apreq.h is not documented.
/include/apreq.h:51: Warning: Member APREQ_DEFAULT_BRIGADE_LIMIT of file
apreq.h is not documented.
/include/apreq.h:52: Warning: Member APREQ_DEFAULT_NELTS of file apreq.h
is not documented.
/include/apreq.h:56: Warning: Member APREQ_FLAGS_OFF(f, name) of file
apreq.h is not documented.
/include/apreq.h:57: Warning: Member APREQ_FLAGS_ON(f, name) of file
apreq.h is not documented.
/include/apreq.h:58: Warning: Member APREQ_FLAGS_GET(f, name) of file
apreq.h is not documented.
/include/apreq.h:61: Warning: Member APREQ_FLAGS_SET(f, name, value) of
file apreq.h is not documented.
/include/apreq.h:64: Warning: Member APREQ_CHARSET_BIT of file apreq.h
is not documented.
/include/apreq.h:65: Warning: Member APREQ_CHARSET_MASK of file apreq.h
is not documented.
/include/apreq.h:67: Warning: Member APREQ_TAINTED_BIT of file apreq.h
is not documented.
/include/apreq.h:68: Warning: Member APREQ_TAINTED_MASK of file apreq.h
is not documented.
/include/apreq.h:70: Warning: Member APREQ_COOKIE_VERSION_BIT of file
apreq.h is not documented.
/include/apreq.h:71: Warning: Member APREQ_COOKIE_VERSION_MASK of file
apreq.h is not documented.
/include/apreq.h:73: Warning: Member APREQ_COOKIE_SECURE_BIT of file
apreq.h is not documented.
/include/apreq.h:74: Warning: Member APREQ_COOKIE_SECURE_MASK of file
apreq.h is not documented.
/include/apreq.h:119: Warning: Member apreq_attr_to_type(T, A, P) of
file apreq.h is not documented.
/include/apreq.h:115: Warning: Member apreq_value_table_add(const
apreq_value_t *v, apr_table_t *t) of file apreq.h is not documented.
/include/apreq_error.h:43: Warning: Member APR_EBADARG of file
apreq_error.h is not documented.
/module/apache2/apreq_module_apache2.h:142: Warning: Member
APREQ_FILTER_NAME of group mod_apreq2 is not documented.
/module/apache2/apreq_module_apache2.h:143: Warning: Member
APREQ_APACHE2_MMN of group mod_apreq2 is not documented
~
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Re: 2.06-dev-rc2 (was Re: 2.0.6-dev [docs preview])
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Philip M. Gollucci wrote:
> Philip M. Gollucci wrote:
>
>>
>>> Cool. I just posted rc2 in the usual place
>>>
>>> http://people.apache.org/~joes/libapreq2-2.06-dev.rc2.tar.gz
> I'll have some "documentation generation" feedback tomorrowish.
With the attached patch
gmake docs docs_install
actually make it all the way through.
Note the addition of feather.gif (attached)
It does:
Replace cp -a with cp -R b/c cp -a is not portable,
Defines POD2HTML as suggested by Michael G. Schwern
<sc...@pobox.com> and uses it as pod2html will not
be in your path if perl isn't.
Use @PERL@ everywhere perl is used as perl might not be
in your path, but we know it from ./configure & ./buildconf
arguments --with-perl.
Uses ${mkinstalldirs} instead of mkdir to prevent directory exist
errors.
Copies the feather.gif file into place instead of 'wgetting' it
remotely.
Next up, I'll try to fix some of the 10million warnings during the
genration of docs.
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Re: 2.06-dev-rc2 (was Re: 2.0.6-dev [docs preview])
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Philip M. Gollucci wrote:
>
>> Cool. I just posted rc2 in the usual place
>>
>> http://people.apache.org/~joes/libapreq2-2.06-dev.rc2.tar.gz
cd perl/glue
./t/TEST t/request.t
t/logs/error_log
[snip]
Attempt to free temp prematurely: SV 0x8349cf4.
[Wed Jul 13 03:12:01 2005] [error] [client 127.0.0.1] Attempt to free
unreferenced scalar: SV 0x8349cf4 at
/usr/local/dev/src/libapreq2-2.06-dev/glue/perl/t/response/TestApReq/request.pm
line 118
The above is from tests 14 causing it and 15-18 to fail.
The below(also attached) patch fixes this. The reason is that
Perl_load_module() "magically frees" the two SVs; notably pkg_name.
With this patch, _ALL_ tests pass on
FreeBSD 6.x-current/i386
perl 5.8.7 no ithreads
httpd 2.0.54/prefork apr not threaded
libapreq=2.0.6-dev-rc2
I'll have some "documentation generation" feedback tomorrowish.
pgollucci@smgellar
/usr/local/dev/repos/ASF/httpd/apreq/trunk/glue/perl/xsbuilder>svn diff
Index: apreq_xs_postperl.h
===================================================================
--- apreq_xs_postperl.h (revision 216120)
+++ apreq_xs_postperl.h (working copy)
@@ -243,7 +243,7 @@
stash = gv_stashpv(ERROR_CLASS, FALSE);
if (stash == NULL) {
- SV *pkg_name = sv_2mortal(newSVpv(class, 0));
+ SV *pkg_name = newSVpv(class, 0);
Perl_load_module(aTHX_ PERL_LOADMOD_NOIMPORT, pkg_name, Nullsv);
stash = gv_stashpv(class, TRUE);
}
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Re: 2.06-dev-rc2 (was Re: 2.0.6-dev [docs preview])
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
>Cool. I just posted rc2 in the usual place
>
> http://people.apache.org/~joes/libapreq2-2.06-dev.rc2.tar.gz
>
>which should include the html docs for the
>APR::Request perl packages.
>
I'll give it a look soonish.
> Please test & report
>(note to Philip: don't test ./buildconf on the
>candidate, always start with ./configure ... or perl
>Makefile.PL ...).
>
>
>
Yeah, I realized that about an hour into it... I have it scripted
for building from SVN... forgot I was testing a release.
--
END
---------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Re: 2.06-dev-rc2 (was Re: 2.0.6-dev [docs preview])
Posted by Ville Skyttä <vi...@iki.fi>.
On Tue, 2005-07-12 at 19:21 -0400, Joe Schaefer wrote:
> http://people.apache.org/~joes/libapreq2-2.06-dev.rc2.tar.gz
>
> which should include the html docs for the
> APR::Request perl packages. Please test & report
Really briefly tested on Fedora Core 3, mod_perl 2.0.1: could not run
the test suite due to some local unrelated issues, but checked the
Apache2::Upload ballooning problem, and could no longer reproduce it.
Re: 2.06-dev-rc2 (was Re: 2.0.6-dev [docs preview])
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Joe Schaefer wrote:
> "Philip M. Gollucci" <pg...@p6m7g8.com> writes:
>
>
>>If anyone wants to preview the docs for 2.0.6-dev,
>>you can see them here:
>>
>>http://libapreq2.p6m7g8.net/
>
>
> Cool. I just posted rc2 in the usual place
>
> http://people.apache.org/~joes/libapreq2-2.06-dev.rc2.tar.gz
>
> which should include the html docs for the
> APR::Request perl packages. Please test & report
I have two failures in t/apreq/request.t:
# received: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
# <html><head>
# <title>500 Internal Server Error</title>
...
# </body></html>
not ok 14
# testing : basic upload length
# expected: 101000
# received: 0
not ok 15
t/logs/error_log has
Apache/2.0.54 (Unix) mod_ssl/2.0.54 OpenSSL/0.9.7a DAV/2 PHP/5.0.4
mod_apreq2-20050712/2.1.2-dev mod_perl/2.0.1-dev Perl/v5.8.7 configured
...
Attempt to free temp prematurely: SV 0x9962628, Perl interpreter: 0x9801530.
[Wed Jul 13 12:02:36 2005] [error] [client 127.0.0.1] Attempt to free
unreferenced scalar: SV 0x9962628, Perl interpreter: 0x9801530 at
/src/libapreq2-2.06-dev/glue/perl/t/response/TestApReq/request.pm line 117
--Geoff
2.06-dev-rc2 (was Re: 2.0.6-dev [docs preview])
Posted by Joe Schaefer <jo...@sunstarsys.com>.
"Philip M. Gollucci" <pg...@p6m7g8.com> writes:
> If anyone wants to preview the docs for 2.0.6-dev,
> you can see them here:
>
> http://libapreq2.p6m7g8.net/
Cool. I just posted rc2 in the usual place
http://people.apache.org/~joes/libapreq2-2.06-dev.rc2.tar.gz
which should include the html docs for the
APR::Request perl packages. Please test & report
(note to Philip: don't test ./buildconf on the
candidate, always start with ./configure ... or perl
Makefile.PL ...).
--
Joe Schaefer