[jira] [Commented] (SYNCOPE-250) Improve error handling in NotificationTest

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYNCOPE-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529759#comment-13529759 ] 

Hudson commented on SYNCOPE-250:
--------------------------------

Integrated in Syncope-trunk #367 (See [https://builds.apache.org/job/Syncope-trunk/367/])
    [SYNCOPE-250] Patch applied: thanks Christian! (Revision 1420564)

     Result = SUCCESS
ilgrosso : 
Files : 
* /syncope/trunk/core/src/test/java/org/apache/syncope/core/notification/NotificationTest.java
* /syncope/trunk/standalone

                
> Improve error handling in NotificationTest
> ------------------------------------------
>
>                 Key: SYNCOPE-250
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-250
>             Project: Syncope
>          Issue Type: Improvement
>    Affects Versions: 1.1.0
>            Reporter: Christian Schneider
>            Assignee: Francesco Chicchiriccò
>             Fix For: 1.1.0
>
>         Attachments: SYNCOPE-250.patch
>
>
> Inside the NotificationTest there are several try catch blocks like below:
> } catch (Exception e) {
>   LOG.error("Unexpected exception", e);
>   fail("Unexpected exception while setting SMTP host and port");
> }
> This makes the code harder to read and at least on the junit level it swallows the exception details and stack trace.
> I propose to remove these blocks and instead let each of these method just throw Exception. junit will then report the exception nicely.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira