You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/08 08:07:33 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11660: [feature-#11636] set ip by specifying

caishunfeng commented on code in PR #11660:
URL: https://github.com/apache/dolphinscheduler/pull/11660#discussion_r965636133


##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java:
##########
@@ -118,9 +119,12 @@ private static synchronized InetAddress getLocalAddress0() {
         if (null != LOCAL_ADDRESS) {
             return LOCAL_ADDRESS;
         }
-
+        String specifyNetworkIP = PropertyUtils.getString(Constants.DOLPHIN_SCHEDULER_NETWORK_IP);

Review Comment:
   It's not a good way to add specify ip logic in method `getLocalAddress0`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org