You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/03 12:39:15 UTC
[GitHub] [airflow] ashb opened a new pull request #14579: Restore correct terminal with to interactive breeze usage
ashb opened a new pull request #14579:
URL: https://github.com/apache/airflow/pull/14579
The change to redirect all breeze output to a file (#14470) had the effect of making stdin no longer a TTY, which meant that the docker container had a fixed with of 80 columns.
The fix is to replace the use of `tee` with `scripts`, which does what we want -- captures stdout+stderr, but makes the running program believe that it is still attached to a terminal (if it ever was).
Tested with `./breeze -n shell -- -c 'set -x; [[ $(tput cols) -gt 80 ]]'`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14579: Restore correct terminal with to interactive breeze usage
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14579:
URL: https://github.com/apache/airflow/pull/14579#issuecomment-789781756
The `script` command on OSX may be slightly different. Testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14579: Restore correct terminal with to interactive breeze usage
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14579:
URL: https://github.com/apache/airflow/pull/14579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14579: Restore correct terminal with to interactive breeze usage
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14579:
URL: https://github.com/apache/airflow/pull/14579#issuecomment-790679115
Will merge without CI -- this doesn't affect them anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14579: Restore correct terminal with to interactive breeze usage
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14579:
URL: https://github.com/apache/airflow/pull/14579#issuecomment-789947105
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14579: Restore correct terminal with to interactive breeze usage
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14579:
URL: https://github.com/apache/airflow/pull/14579#issuecomment-789811694
Yep. It's tricky with 'Posix-ish' level of support on MacOS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14579: Restore correct terminal with to interactive breeze usage
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14579:
URL: https://github.com/apache/airflow/pull/14579#issuecomment-790556444
@kaxil Updated -- could you confirm this works for you on OSX please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14579: Restore correct terminal with to interactive breeze usage
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14579:
URL: https://github.com/apache/airflow/pull/14579#issuecomment-789840792
Just updating brew on my mac laptop to test out a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org