You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/08 12:15:38 UTC
[GitHub] [flink] wangyang0918 opened a new pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
wangyang0918 opened a new pull request #12040:
URL: https://github.com/apache/flink/pull/12040
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Currently, every time we start a flink cluster, flink lib jars need to be uploaded to hdfs and then register Yarn local resource so that it could be downloaded to jobmanager and all taskmanager container. Here we could have two optimizations.
* Use pre-uploaded flink binary to avoid uploading of flink system jars
* By default, the LocalResourceVisibility is APPLICATION, so they will be downloaded only once and shared for all taskmanager containers of a same application in the same node. However, different applications will have to download all jars every time, including the flink-dist.jar. We could use the yarn public cache to eliminate the unnecessary jars downloading and make launching container faster.
How to use the pre-upload feature?
1. First, upload the Flink binary to the HDFS directories
2. Use yarn.provided.lib.dirs to specify the pre-uploaded libs
A final command could be specified like following.
```
./bin/flink run -m yarn-cluster -d -yD yarn.provided.lib.dirs="/flink-lib/flink-1.11-SNAPSHOT/lib;/flink-lib/flink-1.11-SNAPSHOT/plugins" examples/streaming/WindowJoin.jar
```
## Brief change log
* Remove duplicated adding ship files
* Support provided lib dirs
## Verifying this change
* A new test has been added to verify this new feature
* Corresponding unit tests for each new methods and class
* Manually test on a real Yarn cluster
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (will add doc in a separate ticket after FLINK-14964)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-625788237
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 25ba05fcbc87586416bc54cd8b93896a1833525d (Fri May 08 12:18:31 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-625870998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833",
"triggerID" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"triggerType" : "PUSH"
}, {
"hash" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=861",
"triggerID" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"triggerType" : "PUSH"
}, {
"hash" : "910b64e7ecf10d2e6045b967b19c3d38e85fcbed",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "910b64e7ecf10d2e6045b967b19c3d38e85fcbed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=861)
* 910b64e7ecf10d2e6045b967b19c3d38e85fcbed UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-625870998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833",
"triggerID" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"triggerType" : "PUSH"
}, {
"hash" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=861",
"triggerID" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833)
* 7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=861)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-625870998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833",
"triggerID" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-625870998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-625870998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833",
"triggerID" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-625870998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833",
"triggerID" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"triggerType" : "PUSH"
}, {
"hash" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=861",
"triggerID" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"triggerType" : "PUSH"
}, {
"hash" : "910b64e7ecf10d2e6045b967b19c3d38e85fcbed",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=885",
"triggerID" : "910b64e7ecf10d2e6045b967b19c3d38e85fcbed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 910b64e7ecf10d2e6045b967b19c3d38e85fcbed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=885)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-625870998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833",
"triggerID" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"triggerType" : "PUSH"
}, {
"hash" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833)
* 7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-626488446
cc @kl0u could you help with the reviewing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-626664506
@kl0u Thanks a lot for your review. I think it is ok for me to put the comments in your branch. I will integrate your comments asap and then ping you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-625870998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833",
"triggerID" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"triggerType" : "PUSH"
}, {
"hash" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=861",
"triggerID" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"triggerType" : "PUSH"
}, {
"hash" : "910b64e7ecf10d2e6045b967b19c3d38e85fcbed",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=885",
"triggerID" : "910b64e7ecf10d2e6045b967b19c3d38e85fcbed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=861)
* 910b64e7ecf10d2e6045b967b19c3d38e85fcbed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=885)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12040: [FLINK-13938][yarn] Use provided lib dirs to accelerate flink submission
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12040:
URL: https://github.com/apache/flink/pull/12040#issuecomment-625870998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=833",
"triggerID" : "5e0bf74fa324d9c8f69c6ccb1f639a17b78d0837",
"triggerType" : "PUSH"
}, {
"hash" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=861",
"triggerID" : "7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7cc8e51c13f7ad50c8b4ee53c976b1ab842bcc86 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=861)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org