You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/13 00:36:54 UTC
[kudu-CR] tidy: add and fix modernize-make-shared
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7161
to review the following change.
Change subject: tidy: add and fix modernize-make-shared
......................................................................
tidy: add and fix modernize-make-shared
Also ran tidy --fix to apply these changes.
Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
---
M src/kudu/.clang-tidy
M src/kudu/cfile/type_encodings.cc
M src/kudu/cfile/type_encodings.h
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/util/map-util-test.cc
10 files changed, 22 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/7161/1
--
To view, visit http://gerrit.cloudera.org:8080/7161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] tidy: add and fix modernize-make-shared
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tidy: add and fix modernize-make-shared
......................................................................
Patch Set 2: Verified+1
test failure seems unrelated
--
To view, visit http://gerrit.cloudera.org:8080/7161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tidy: add and fix modernize-make-shared
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has uploaded a new patch set (#2).
Change subject: tidy: add and fix modernize-make-shared
......................................................................
tidy: add and fix modernize-make-shared
Also ran tidy --fix to apply these changes.
Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
---
M src/kudu/.clang-tidy
M src/kudu/cfile/type_encodings.cc
M src/kudu/cfile/type_encodings.h
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/util/map-util-test.cc
10 files changed, 21 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/7161/2
--
To view, visit http://gerrit.cloudera.org:8080/7161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tidy: add and fix modernize-make-shared
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: tidy: add and fix modernize-make-shared
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7161/1/src/kudu/tablet/lock_manager-test.cc
File src/kudu/tablet/lock_manager-test.cc:
Line 163: locks.push_back(std::make_shared<ScopedRowLock>(
formatting here. The changes below may be able to squeeze on to one line now.
--
To view, visit http://gerrit.cloudera.org:8080/7161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tidy: add and fix modernize-make-shared
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: tidy: add and fix modernize-make-shared
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tidy: add and fix modernize-make-shared
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tidy: add and fix modernize-make-shared
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7161/1/src/kudu/cfile/type_encodings.h
File src/kudu/cfile/type_encodings.h:
Line 58: template<typename TypeEncodingTraitsClass> TypeEncodingInfo(TypeEncodingTraitsClass t);
> warning: single-argument constructors must be marked explicit to avoid unin
I'll fix these unrelated tidy warnings separately
--
To view, visit http://gerrit.cloudera.org:8080/7161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tidy: add and fix modernize-make-shared
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tidy: add and fix modernize-make-shared
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7161/1/src/kudu/tablet/lock_manager-test.cc
File src/kudu/tablet/lock_manager-test.cc:
Line 163: locks.push_back(std::make_shared<ScopedRowLock>(
> formatting here. The changes below may be able to squeeze on to one line n
Done
--
To view, visit http://gerrit.cloudera.org:8080/7161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tidy: add and fix modernize-make-shared
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: tidy: add and fix modernize-make-shared
......................................................................
tidy: add and fix modernize-make-shared
Also ran tidy --fix to apply these changes.
Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
Reviewed-on: http://gerrit.cloudera.org:8080/7161
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/.clang-tidy
M src/kudu/cfile/type_encodings.cc
M src/kudu/cfile/type_encodings.h
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/util/map-util-test.cc
10 files changed, 21 insertions(+), 19 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>