You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "D.J. Heap" <dj...@gmail.com> on 2005/11/11 16:16:54 UTC
Re: svn trunk r17300: FAIL (win32 ra_local fsfs)
> FAIL: commit_tests.py 34: post commit hook failure case testing
This last failure is due to a '\r\n' rather than just a '\n' being
outputted by the hook -- everything else seems to be fine. I'm not
sure if it's Python or Windows stderr doing it...reading the Python
docs leads me to believe it is Python -- but I'm not sure. Maybe a
Python expert knows some way to suppress it if it is Python?
DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r17300: FAIL (win32 ra_local fsfs)
Posted by David James <ja...@gmail.com>.
On 11/11/05, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> On 11/11/05, D.J. Heap <dj...@gmail.com> wrote:
>
> > This tweak to the test scripts works around the newline issue (doesn't
> > output the newline in the hook output). I'm not sure if it's an
> > acceptable solution though:
>
> That seems acceptable to me.
+1. Thanks for looking into this!
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
Re: svn trunk r17300: FAIL (win32 ra_local fsfs)
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 11/11/05, D.J. Heap <dj...@gmail.com> wrote:
> This tweak to the test scripts works around the newline issue (doesn't
> output the newline in the hook output). I'm not sure if it's an
> acceptable solution though:
That seems acceptable to me.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r17300: FAIL (win32 ra_local fsfs)
Posted by "D.J. Heap" <dj...@gmail.com>.
On 11/11/05, D.J. Heap <dj...@gmail.com> wrote:
> > FAIL: commit_tests.py 34: post commit hook failure case testing
>
>
> This last failure is due to a '\r\n' rather than just a '\n' being
> outputted by the hook -- everything else seems to be fine. I'm not
> sure if it's Python or Windows stderr doing it...reading the Python
> docs leads me to believe it is Python -- but I'm not sure. Maybe a
> Python expert knows some way to suppress it if it is Python?
>
> DJ
>
This tweak to the test scripts works around the newline issue (doesn't
output the newline in the hook output). I'm not sure if it's an
acceptable solution though:
Index: subversion/tests/clients/cmdline/commit_tests.py
===================================================================
--- subversion/tests/clients/cmdline/commit_tests.py (revision 17301)
+++ subversion/tests/clients/cmdline/commit_tests.py (working copy)
@@ -1984,7 +1984,6 @@
"\n",
"Warning: 'post-commit' hook failed with error
output:\n",
"Post-commit hook failed\n",
- "\n"
]
svntest.actions.run_and_verify_svn (None, expected_output, [],
Index: subversion/tests/clients/cmdline/svntest/actions.py
===================================================================
--- subversion/tests/clients/cmdline/svntest/actions.py (revision 17301)
+++ subversion/tests/clients/cmdline/svntest/actions.py (working copy)
@@ -821,6 +821,6 @@
hook_path = main.get_post_commit_hook_path (repo_dir)
main.create_python_hook_script (hook_path, 'import sys; '
- 'print >>sys.stderr, "Post-commit hook failed"; '
+ 'sys.stderr.write("Post-commit hook failed"); '
'sys.exit(1)')
### End of file.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org