You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "seifertdan (via GitHub)" <gi...@apache.org> on 2024/07/17 12:00:58 UTC
[PR] Add AWS region me-central-1 [libcloud]
seifertdan opened a new pull request, #2030:
URL: https://github.com/apache/libcloud/pull/2030
## Changes Title (replace this with a logical title for your changes)
### Description
Replace this with the PR description (mention the changes you have made, why
you have made them, provide some background and any references to the provider
documentation if needed, etc.).
For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
section of our documentation.
### Status
Replace this: describe the PR status. Examples:
- work in progress
- done, ready for review
### Checklist (tick everything that applies)
- [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add AWS region me-central-1 [libcloud]
Posted by "elakito (via GitHub)" <gi...@apache.org>.
elakito commented on PR #2030:
URL: https://github.com/apache/libcloud/pull/2030#issuecomment-2260064067
Is this PR ready for review or someone can investigate the problem? I also tried running the tox, scrape-ec2-sizes.py downloads a 6GB ec.json file, which looks okay. But this script prints this error.
```
Using data from existing cached file /tmp/ec.json
scrape-ec2-sizes: exit -9 (837.75 seconds) /opt/libcloud> bash -c 'python contrib/scrape-ec2-sizes.py' pid=28
scrape-ec2-sizes: FAIL ✖ in 13 minutes 58.98 seconds
```
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add AWS region me-central-1 [libcloud]
Posted by "Kami (via GitHub)" <gi...@apache.org>.
Kami commented on PR #2030:
URL: https://github.com/apache/libcloud/pull/2030#issuecomment-2692832798
Sorry for the delay. The PR (with somewhat related updates to AWS EC2 sizes and prices) has been merged into trunk.
Thanks for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add AWS region me-central-1 [libcloud]
Posted by "Kami (via GitHub)" <gi...@apache.org>.
Kami merged PR #2030:
URL: https://github.com/apache/libcloud/pull/2030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add AWS region me-central-1 [libcloud]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2030:
URL: https://github.com/apache/libcloud/pull/2030#issuecomment-2692832414
## [Codecov](https://app.codecov.io/gh/apache/libcloud/pull/2030?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 83.40%. Comparing base [(`1117987`)](https://app.codecov.io/gh/apache/libcloud/commit/1117987d9a1171561bdbc51b6dd27023638a28b3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0a5bc0d`)](https://app.codecov.io/gh/apache/libcloud/commit/0a5bc0d594578af1f745d5255875c3fd85dc3f5e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## trunk #2030 +/- ##
=======================================
Coverage 83.40% 83.40%
=======================================
Files 353 353
Lines 81685 81685
Branches 8632 8632
=======================================
Hits 68124 68124
Misses 10738 10738
Partials 2823 2823
```
| [Files with missing lines](https://app.codecov.io/gh/apache/libcloud/pull/2030?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/constants/ec2\_instance\_types.py](https://app.codecov.io/gh/apache/libcloud/pull/2030?src=pr&el=tree&filepath=libcloud%2Fcompute%2Fconstants%2Fec2_instance_types.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX2luc3RhbmNlX3R5cGVzLnB5) | `100.00% <ø> (ø)` | |
| [...d/compute/constants/ec2\_region\_details\_complete.py](https://app.codecov.io/gh/apache/libcloud/pull/2030?src=pr&el=tree&filepath=libcloud%2Fcompute%2Fconstants%2Fec2_region_details_complete.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX2NvbXBsZXRlLnB5) | `100.00% <ø> (ø)` | |
| [libcloud/storage/drivers/s3.py](https://app.codecov.io/gh/apache/libcloud/pull/2030?src=pr&el=tree&filepath=libcloud%2Fstorage%2Fdrivers%2Fs3.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvc3RvcmFnZS9kcml2ZXJzL3MzLnB5) | `89.61% <ø> (ø)` | |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add AWS region me-central-1 [libcloud]
Posted by "seifertdan (via GitHub)" <gi...@apache.org>.
seifertdan closed pull request #2030: Add AWS region me-central-1
URL: https://github.com/apache/libcloud/pull/2030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org