You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2022/04/06 14:58:10 UTC

Re: Review Request 73880: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73880/#review224258
-----------------------------------------------------------




plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
Lines 257 (patched)
<https://reviews.apache.org/r/73880/#comment313132>

    Can the clientAddress() be null?


- Ramesh Mani


On March 26, 2022, 10:54 a.m., Andras Katona wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73880/
> -----------------------------------------------------------
> 
> (Updated March 26, 2022, 10:54 a.m.)
> 
> 
> Review request for ranger and Ramesh Mani.
> 
> 
> Bugs: RANGER-3231
>     https://issues.apache.org/jira/browse/RANGER-3231
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> kafka.security.auth.Authorizer has been deprecated since December 2019, and
> it's removed in Apache Kafka 3.0
> 
> 
> Diffs
> -----
> 
>   plugin-kafka/pom.xml d95f591fe 
>   plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 97a2f2ec7 
>   ranger-kafka-plugin-shim/pom.xml 3264138a8 
>   ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java b84b765c2 
> 
> 
> Diff: https://reviews.apache.org/r/73880/diff/3/
> 
> 
> Testing
> -------
> 
> unit tests executed via maven
> 
> related PR: https://github.com/apache/ranger/pull/133 - currently executing checks, last time failed with unrelated compile error: missing dependency
> 
> 
> Thanks,
> 
> Andras Katona
> 
>