You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/11/03 07:44:22 UTC
[GitHub] [ozone] JacksonYao287 opened a new pull request #2793: HDDS-5922. ignore deletetransaction when container is not found
JacksonYao287 opened a new pull request #2793:
URL: https://github.com/apache/ozone/pull/2793
## What changes were proposed in this pull request?
ignore deletetransaction when container is not found
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5922
## How was this patch tested?
no need add more ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2793: HDDS-5922. ignore deletetransaction when container is not found
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2793:
URL: https://github.com/apache/ozone/pull/2793#discussion_r745236145
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManagerImpl.java
##########
@@ -415,6 +415,11 @@ public void updateDeleteTransactionId(
deleteTransactionMap.entrySet()) {
final ContainerInfo info = containers.getContainerInfo(
transaction.getKey());
+ if (info == null) {
+ LOG.warn("can not find container id {}, transaction id is {}",
Review comment:
can not -> Cannot , container id -> container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2793: HDDS-5922. ignore deletetransaction when container is not found
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2793:
URL: https://github.com/apache/ozone/pull/2793#issuecomment-964863055
thanks @ChenSammi for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on a change in pull request #2793: HDDS-5922. ignore deletetransaction when container is not found
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on a change in pull request #2793:
URL: https://github.com/apache/ozone/pull/2793#discussion_r745238664
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManagerImpl.java
##########
@@ -415,6 +415,11 @@ public void updateDeleteTransactionId(
deleteTransactionMap.entrySet()) {
final ContainerInfo info = containers.getContainerInfo(
transaction.getKey());
+ if (info == null) {
+ LOG.warn("can not find container id {}, transaction id is {}",
Review comment:
thanks @ChenSammi for the review, will fix this comment in a new commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #2793: HDDS-5922. ignore deletetransaction when container is not found
Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #2793:
URL: https://github.com/apache/ozone/pull/2793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2793: HDDS-5922. ignore deletetransaction when container is not found
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2793:
URL: https://github.com/apache/ozone/pull/2793#issuecomment-964861841
LGTM, +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2793: HDDS-5922. ignore deletetransaction when container is not found
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2793:
URL: https://github.com/apache/ozone/pull/2793#issuecomment-960449022
@ChenSammi please take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org