You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "gesterzhou (GitHub)" <gi...@apache.org> on 2018/10/18 00:08:59 UTC
[GitHub] [geode] gesterzhou opened pull request #2649: GEODE-5890: gateway events from the same distributed system should ch…
…eck misorder
@jhuynh1 @boglesby
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2649 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt commented on pull request #2649: GEODE-5890: gateway events from the same distributed system should ch…
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
The only difference is this new change will prevent any registered `GatewayConflictResolvers` from being invoked in the case where `tagTime > stampTime`. Is that what we want?
[ Full content available at: https://github.com/apache/geode/pull/2649 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] gesterzhou closed pull request #2649: GEODE-5890: gateway events from the same distributed system should ch…
Posted by "gesterzhou (GitHub)" <gi...@apache.org>.
[ pull request closed by gesterzhou ]
[ Full content available at: https://github.com/apache/geode/pull/2649 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt commented on pull request #2649: GEODE-5890: gateway events from the same distributed system should ch…
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
Isn't this doing the same check (effectively) as the one on line 2162? It is covered by the `tagTime > stampTime` and `tagDsid >= stampDsid` checks on that line. The code on line 2162 could be consolidated into this, but that's a separate observation:
if (tagTime >= stampTime && tagDsid >= stampDsid)
[ Full content available at: https://github.com/apache/geode/pull/2649 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org