[GitHub] [apisix] crazyMonkey1995 commented on a diff in pull request #6686: fix(redirect): set redirect server port when enable http_to_https

[GitBox <gi...@apache.org>]

crazyMonkey1995 commented on code in PR #6686:
URL: https://github.com/apache/apisix/pull/6686#discussion_r867816800


##########
apisix/plugins/redirect.lua:
##########
@@ -147,6 +148,7 @@ function _M.rewrite(conf, ctx)
     core.log.info("plugin rewrite phase, conf: ", core.json.delay_encode(conf))
 
     local ret_code = conf.ret_code
+    local ret_port = tonumber(ctx.var["var_x_forwarded_port"])

Review Comment:
   
   Recently, I upgraded apisix with the latest code, and found that there was an error in converting http to https. When redirecting, I always bring a port 80. It should be caused by this change, because I am listening on port 80 and port 443, but ngx_tpl There is a piece of code in it that is "set $var_x_forwarded_port $server_port;", which means that the port from http to https is always the same. I don't think this change is very reasonable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org