You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/28 02:36:43 UTC

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #22468: 19937 federation optimization test 20221128

strongduanmu commented on code in PR #22468:
URL: https://github.com/apache/shardingsphere/pull/22468#discussion_r1033073676


##########
kernel/sql-federation/optimizer/src/test/java/org/apache/shardingsphere/sqlfederation/optimizer/SQLOptimizeEngineTest.java:
##########
@@ -89,6 +89,11 @@ public void init() {
         Map<String, ShardingSphereTable> tables = new HashMap<>(2, 1);
         tables.put("t_order_federate", createOrderTableMetaData());
         tables.put("t_user_info", createUserInfoTableMetaData());
+        tables.put("t_order", createTOrderTableMetaData());
+        tables.put("t_order_item", createTOrderItemTableMetaData());
+        tables.put("t_single_table", createTSingleTableMetaData());
+        tables.put("t_order_federate_sharding", createTOrderFederateShardingMetaData());

Review Comment:
   Can we use standard table? t_single_table, t_order_federate_sharding and t_order_item_federate_sharding will be removed in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org