You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by amihalik <gi...@git.apache.org> on 2016/08/24 23:10:53 UTC

[GitHub] incubator-rya pull request #80: RYA-163 PCJDetails Test Failures on non-EST ...

Github user amihalik commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/80#discussion_r76156372
  
    --- Diff: extras/rya.console/src/test/java/mvm/rya/shell/RyaAdminCommandsTest.java ---
    @@ -123,6 +124,9 @@ public void deletePCJ() throws InstanceDoesNotExistException, RyaClientException
     
         @Test
         public void getInstanceDetails() throws InstanceDoesNotExistException, RyaClientException {
    +        // This test is failed if the default timezone was not EST, so now it's fixed at EST.
    +        // If you get assert mismatch of EST!=EDT, try the deprecated getTimeZone("EST") instead.
    +        TimeZone.setDefault(TimeZone.getTimeZone("America/New_York"));
    --- End diff --
    
    You made a good point in in the JIRA ticket... I think everything worked for me because the order of the test execution.  Can you move this to a static class initializer or a BeforeClass method (so that the order of the test within this file doesn't break things)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---