You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 13:22:30 UTC
[GitHub] [flink] TsReaper opened a new pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
TsReaper opened a new pull request #13793:
URL: https://github.com/apache/flink/pull/13793
## What is the purpose of the change
The new version of Calcite introduces the `SEARCH` rex call to express range conditions. However `SEARCH`es in conjunctions are currently not simplified. For example, `AND(=($2, 2020), SEARCH($2, Sarg[2020, 2021]))` is not simplified while it should be simplified to `=($2, 2020)`.
This PR expands the `SEARCH` rex calls in `FlinkRexUtil#simplify` to achieve this. `RexSimplify#simplify` in Calcite will do the rest of the work.
## Brief change log
- Simplify `SEARCH`es in conjunctions in `FlinkRexUtil#simplify`
## Verifying this change
This change added tests and can be verified by running the added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #13793:
URL: https://github.com/apache/flink/pull/13793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TsReaper commented on a change in pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
TsReaper commented on a change in pull request #13793:
URL: https://github.com/apache/flink/pull/13793#discussion_r512101883
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala
##########
@@ -196,14 +196,23 @@ object FlinkRexUtil {
* 4. (a > b OR c < 10) OR b < a -> a > b OR c < 10
* 5. a = a, a >= a, a <= a -> true
* 6. a <> a, a > a, a < a -> false
+ * 7. a = 2020 AND SEARCH(a, [2020, 2021]) -> a = 2020
Review comment:
Obviously it can't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #13793:
URL: https://github.com/apache/flink/pull/13793#discussion_r511982465
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala
##########
@@ -196,14 +196,23 @@ object FlinkRexUtil {
* 4. (a > b OR c < 10) OR b < a -> a > b OR c < 10
* 5. a = a, a >= a, a <= a -> true
* 6. a <> a, a > a, a < a -> false
+ * 7. a = 2020 AND SEARCH(a, [2020, 2021]) -> a = 2020
Review comment:
does `a = 2020 OR SEARCH(a, [2020, 2021])` can be simplified as `a = 2020` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13793:
URL: https://github.com/apache/flink/pull/13793#issuecomment-716625439
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8314",
"triggerID" : "dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856",
"triggerType" : "PUSH"
}, {
"hash" : "2320004768e00086c264056f67bddb21613374db",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8346",
"triggerID" : "2320004768e00086c264056f67bddb21613374db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2320004768e00086c264056f67bddb21613374db Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8346)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13793:
URL: https://github.com/apache/flink/pull/13793#issuecomment-716625439
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8314",
"triggerID" : "dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856",
"triggerType" : "PUSH"
}, {
"hash" : "2320004768e00086c264056f67bddb21613374db",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2320004768e00086c264056f67bddb21613374db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8314)
* 2320004768e00086c264056f67bddb21613374db UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #13793:
URL: https://github.com/apache/flink/pull/13793#issuecomment-716967458
update the title as "Simplify SEARCHes in FlinkRexUtil#simplify"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #13793:
URL: https://github.com/apache/flink/pull/13793#issuecomment-722154682
replaced by https://github.com/apache/flink/pull/13931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TsReaper commented on a change in pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
TsReaper commented on a change in pull request #13793:
URL: https://github.com/apache/flink/pull/13793#discussion_r512380855
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala
##########
@@ -196,14 +196,23 @@ object FlinkRexUtil {
* 4. (a > b OR c < 10) OR b < a -> a > b OR c < 10
* 5. a = a, a >= a, a <= a -> true
* 6. a <> a, a > a, a < a -> false
+ * 7. a = 2020 AND SEARCH(a, [2020, 2021]) -> a = 2020
Review comment:
This should be simplified as `SEARCH(a, [2020, 2021])`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13793:
URL: https://github.com/apache/flink/pull/13793#issuecomment-716625439
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13793:
URL: https://github.com/apache/flink/pull/13793#issuecomment-716543842
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856 (Mon Oct 26 13:25:36 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19811).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13793:
URL: https://github.com/apache/flink/pull/13793#issuecomment-716625439
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8314",
"triggerID" : "dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8314)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TsReaper commented on a change in pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
TsReaper commented on a change in pull request #13793:
URL: https://github.com/apache/flink/pull/13793#discussion_r512101883
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala
##########
@@ -196,14 +196,23 @@ object FlinkRexUtil {
* 4. (a > b OR c < 10) OR b < a -> a > b OR c < 10
* 5. a = a, a >= a, a <= a -> true
* 6. a <> a, a > a, a < a -> false
+ * 7. a = 2020 AND SEARCH(a, [2020, 2021]) -> a = 2020
Review comment:
Obviously it can't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in conjunctions in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13793:
URL: https://github.com/apache/flink/pull/13793#issuecomment-716625439
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8314",
"triggerID" : "dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbd532ce6d9cb6bb713eb794fdb10e79ba2e3856 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8314)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13793: [FLINK-19811][table-planner-blink] Simplify SEARCHes in FlinkRexUtil#simplify
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13793:
URL: https://github.com/apache/flink/pull/13793#issuecomment-716625439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org