You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/04/24 20:08:24 UTC
Review Request 20677: Patch for KAFKA-1392
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20677/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1392
https://issues.apache.org/jira/browse/KAFKA-1392
Repository: kafka
Description
-------
1. Throw exception in waitUntilTrue() if timeout is reached. 2. Fixed unit test failure because of 1 in testResumePartitionReassignmentThatWasCompleted (a. should wait until reassignment path is deleted; b. under replicated check should be wrapped in waitUntilTrue).
Diffs
-----
core/src/test/scala/unit/kafka/admin/AdminTest.scala 3a6c5ffa7e27d871a5cfb250c85b0609644b7cf9
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 6d489adcb307d4bffc5d36ff65ff1b16f474d4e4
core/src/test/scala/unit/kafka/network/SocketServerTest.scala c3b1ac445cf496dede87267a9601a466e453fecc
core/src/test/scala/unit/kafka/producer/ProducerTest.scala c1219a8b9bd1188190cf1f50eec844e97dcd1ba0
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala b278bb6eaa49d8dbe3b70463fdd4cc854f4796fe
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 3fb08e69446aba2363255d9853a02c455ac46e11
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
Diff: https://reviews.apache.org/r/20677/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 20677: Patch for KAFKA-1392
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20677/#review41363
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On April 24, 2014, 6:08 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20677/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 6:08 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1392
> https://issues.apache.org/jira/browse/KAFKA-1392
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Throw exception in waitUntilTrue() if timeout is reached. 2. Fixed unit test failure because of 1 in testResumePartitionReassignmentThatWasCompleted (a. should wait until reassignment path is deleted; b. under replicated check should be wrapped in waitUntilTrue).
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/admin/AdminTest.scala 3a6c5ffa7e27d871a5cfb250c85b0609644b7cf9
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 6d489adcb307d4bffc5d36ff65ff1b16f474d4e4
> core/src/test/scala/unit/kafka/network/SocketServerTest.scala c3b1ac445cf496dede87267a9601a466e453fecc
> core/src/test/scala/unit/kafka/producer/ProducerTest.scala c1219a8b9bd1188190cf1f50eec844e97dcd1ba0
> core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala b278bb6eaa49d8dbe3b70463fdd4cc854f4796fe
> core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 3fb08e69446aba2363255d9853a02c455ac46e11
> core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
> core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
>
> Diff: https://reviews.apache.org/r/20677/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20677: Patch for KAFKA-1392
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20677/
-----------------------------------------------------------
(Updated April 24, 2014, 10:49 p.m.)
Review request for kafka.
Changes
-------
Upload v2 to address Joel's comments.
Bugs: KAFKA-1392
https://issues.apache.org/jira/browse/KAFKA-1392
Repository: kafka
Description
-------
1. Throw exception in waitUntilTrue() if timeout is reached. 2. Fixed unit test failure because of 1 in testResumePartitionReassignmentThatWasCompleted (a. should wait until reassignment path is deleted; b. under replicated check should be wrapped in waitUntilTrue).
Diffs
-----
core/src/test/scala/unit/kafka/admin/AdminTest.scala 3a6c5ffa7e27d871a5cfb250c85b0609644b7cf9
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 6d489adcb307d4bffc5d36ff65ff1b16f474d4e4
core/src/test/scala/unit/kafka/network/SocketServerTest.scala c3b1ac445cf496dede87267a9601a466e453fecc
core/src/test/scala/unit/kafka/producer/ProducerTest.scala c1219a8b9bd1188190cf1f50eec844e97dcd1ba0
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala b278bb6eaa49d8dbe3b70463fdd4cc854f4796fe
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 3fb08e69446aba2363255d9853a02c455ac46e11
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
Diff: https://reviews.apache.org/r/20677/diff/
Testing
-------
File Attachments (updated)
----------------
v2
https://reviews.apache.org/media/uploaded/files/2014/04/24/73a76390-4003-4ba7-93ea-46190d47acc8__kafka-1392.patch
Thanks,
Jun Rao
Re: Review Request 20677: Patch for KAFKA-1392
Posted by Jun Rao <ju...@gmail.com>.
> On April 24, 2014, 9:27 p.m., Joel Koshy wrote:
> > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 244
> > <https://reviews.apache.org/r/20677/diff/1/?file=567941#file567941line244>
> >
> > Just curious: why are we using the checkpoint interval as the wait time here?
Yes, they don't need to use the checkpoint interval.
- Jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20677/#review41388
-----------------------------------------------------------
On April 24, 2014, 6:08 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20677/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 6:08 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1392
> https://issues.apache.org/jira/browse/KAFKA-1392
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Throw exception in waitUntilTrue() if timeout is reached. 2. Fixed unit test failure because of 1 in testResumePartitionReassignmentThatWasCompleted (a. should wait until reassignment path is deleted; b. under replicated check should be wrapped in waitUntilTrue).
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/admin/AdminTest.scala 3a6c5ffa7e27d871a5cfb250c85b0609644b7cf9
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 6d489adcb307d4bffc5d36ff65ff1b16f474d4e4
> core/src/test/scala/unit/kafka/network/SocketServerTest.scala c3b1ac445cf496dede87267a9601a466e453fecc
> core/src/test/scala/unit/kafka/producer/ProducerTest.scala c1219a8b9bd1188190cf1f50eec844e97dcd1ba0
> core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala b278bb6eaa49d8dbe3b70463fdd4cc854f4796fe
> core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 3fb08e69446aba2363255d9853a02c455ac46e11
> core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
> core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
>
> Diff: https://reviews.apache.org/r/20677/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20677: Patch for KAFKA-1392
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20677/#review41388
-----------------------------------------------------------
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala
<https://reviews.apache.org/r/20677/#comment74825>
Just curious: why are we using the checkpoint interval as the wait time here?
core/src/test/scala/unit/kafka/utils/TestUtils.scala
<https://reviews.apache.org/r/20677/#comment74827>
msg not used
core/src/test/scala/unit/kafka/utils/TestUtils.scala
<https://reviews.apache.org/r/20677/#comment74829>
When we hit this, what does the test output look like? i.e., I'm wondering if it is better to Assert.fail? Does a RuntimeException allow the rest of the tests in the suite proceed?
- Joel Koshy
On April 24, 2014, 6:08 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20677/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 6:08 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1392
> https://issues.apache.org/jira/browse/KAFKA-1392
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Throw exception in waitUntilTrue() if timeout is reached. 2. Fixed unit test failure because of 1 in testResumePartitionReassignmentThatWasCompleted (a. should wait until reassignment path is deleted; b. under replicated check should be wrapped in waitUntilTrue).
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/admin/AdminTest.scala 3a6c5ffa7e27d871a5cfb250c85b0609644b7cf9
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 6d489adcb307d4bffc5d36ff65ff1b16f474d4e4
> core/src/test/scala/unit/kafka/network/SocketServerTest.scala c3b1ac445cf496dede87267a9601a466e453fecc
> core/src/test/scala/unit/kafka/producer/ProducerTest.scala c1219a8b9bd1188190cf1f50eec844e97dcd1ba0
> core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala b278bb6eaa49d8dbe3b70463fdd4cc854f4796fe
> core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 3fb08e69446aba2363255d9853a02c455ac46e11
> core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
> core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
>
> Diff: https://reviews.apache.org/r/20677/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>