You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ant.apache.org by bu...@apache.org on 2008/10/21 17:07:21 UTC

DO NOT REPLY [Bug 42632] Jar task may not close all input streams?

https://issues.apache.org/bugzilla/show_bug.cgi?id=42632


Stefan Bodewig <bo...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |notifications@ant.apache.org
         AssignedTo|notifications@ant.apache.org|bodewig@apache.org
   Target Milestone|---                         |1.8.0




--- Comment #3 from Stefan Bodewig <bo...@apache.org>  2008-10-21 08:07:19 PST ---
I agree with Martijn.

filesetmanifest() doesn't close the reader if and only if it is called from
within zipFile() with a non-null InputStream.  The caller of zipFile is the
owner of that InputStream and responsible for closing it IMHO.

I had a look through Zip and it closes the streams after calling zipFile(). 
Jar looks different  with writeServices and writeManifest, but the streams are
ByteArrayInputStreams only.

Will check the other subclasses and add a JavaDoc statement to the zipFile
method.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.