You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/12 02:22:38 UTC
[GitHub] jai1 commented on a change in pull request #1002: Making Pulsar Proxy more secure
jai1 commented on a change in pull request #1002: Making Pulsar Proxy more secure
URL: https://github.com/apache/incubator-pulsar/pull/1002#discussion_r161127527
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -98,7 +98,7 @@
private String clientVersion = null;
private int nonPersistentPendingMessages = 0;
private final int MaxNonPersistentPendingMessages;
- private String originalPrincipal;
+ private String proxyClientAuthRole = null;
Review comment:
Three reasons:-
- Principal is specific to athens
- we traditionally used auth*Role* to store the auth data
- proxyClient is more specific than original
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services