You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Nitin Mehta <ni...@citrix.com> on 2013/10/06 21:47:01 UTC
Re: Review Request 14076: New test added for template copy feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14076/#review26713
-----------------------------------------------------------
test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52028>
there should be source zone id as well
test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52029>
Is this a blocking call ? Have you tested this ? Does it return success
test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52035>
Why are these assertions required when we repeat them in the loop ?
test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52031>
change the comment
test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52032>
Change this comment...this confused me...
Say something like "check template downloaded by polling, then delete it finally"
test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52034>
timeout is generally is not a count...what is the value typically u will keep ?
test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52033>
how long will the sleep will be for ?
- Nitin Mehta
On Sept. 18, 2013, 2:29 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14076/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2013, 2:29 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Harikrishna Patnala, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added one missing test for test_templates.py from old QA repo to Cloudstack
>
> def test_02_copy_template
>
>
> Diffs
> -----
>
> test/integration/component/test_templates.py e4599d4
>
> Diff: https://reviews.apache.org/r/14076/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14076: New test added for template copy feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Oct. 6, 2013, 7:47 p.m., Nitin Mehta wrote:
> > test/integration/component/test_templates.py, line 441
> > <https://reviews.apache.org/r/14076/diff/1/?file=350749#file350749line441>
> >
> > Is this a blocking call ? Have you tested this ? Does it return success
Added method in base.py so the call is sync now. I have run the test case and tested.
> On Oct. 6, 2013, 7:47 p.m., Nitin Mehta wrote:
> > test/integration/component/test_templates.py, line 476
> > <https://reviews.apache.org/r/14076/diff/1/?file=350749#file350749line476>
> >
> > timeout is generally is not a count...what is the value typically u will keep ?
> >
Using 10 as its value. The loop will check 10 times if the template is copied or not each time waiting for a fixed interval of time.
> On Oct. 6, 2013, 7:47 p.m., Nitin Mehta wrote:
> > test/integration/component/test_templates.py, line 478
> > <https://reviews.apache.org/r/14076/diff/1/?file=350749#file350749line478>
> >
> > how long will the sleep will be for ?
Sleep timer is 30 Secs. There no global setting parameter timeout value related to this. Considering 30 Secs time is good enough to wait.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14076/#review26713
-----------------------------------------------------------
On Oct. 8, 2013, 1:45 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14076/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 1:45 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Harikrishna Patnala, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added one missing test for test_templates.py from old QA repo to Cloudstack
>
> def test_02_copy_template
>
>
> Diffs
> -----
>
> test/integration/component/test_templates.py ea4b277
> tools/marvin/marvin/integration/lib/base.py 0d52224
>
> Diff: https://reviews.apache.org/r/14076/diff/
>
>
> Testing
> -------
>
> Run log:
> ==> client.log <==
> 2013-10-08 00:23:44,306 - DEBUG - test_02_copy_template (test_templates_fixed.TestTemplates) - Copying template from zone: 79ed0a9e-469c-460d-b674-0a2
> to 10c91f7e-06ed-47e4-a1fd-26d9102e9d6f
>
> ==> result.log <==
> skipped 'Skip'
> test_01_create_template_volume (test_templates_fixed.TestTemplates)
> Test Create template from volume ... skipped 'Skip'
> test_02_copy_template (test_templates_fixed.TestTemplates)
> Test for copy template from one zone to another ... ok
> test_03_delete_template (test_templates_fixed.TestTemplates)
> Test Delete template ... skipped 'Skip'
> test_04_template_from_snapshot (test_templates_fixed.TestTemplates)
> Create Template from snapshot ... skipped 'Skip'
>
> ----------------------------------------------------------------------
> Ran 5 tests in 567.935s
>
> OK (skipped=4)
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>