You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Chad Dombrova (Jira)" <ji...@apache.org> on 2019/12/20 23:01:00 UTC
[jira] [Commented] (BEAM-9012) Include `-> None` on Pipeline and
PipelineOptions `__init__` methods for pytype compatibility
[ https://issues.apache.org/jira/browse/BEAM-9012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001279#comment-17001279 ]
Chad Dombrova commented on BEAM-9012:
-------------------------------------
Fine by me. Brian, if you're into the static typing thing, you may want to poke in over at my second PR, which is waiting on some feedback: [https://github.com/apache/beam/pull/10367]
There will probably be a third (and hopefully final) PR after that one to get the project to a point where mypy is fully passing. We can take care of this issue in that final PR.
> Include `-> None` on Pipeline and PipelineOptions `__init__` methods for pytype compatibility
> ---------------------------------------------------------------------------------------------
>
> Key: BEAM-9012
> URL: https://issues.apache.org/jira/browse/BEAM-9012
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Fix For: 2.19.0
>
>
> mypy [made a decision|https://github.com/python/mypy/issues/604] to allow init methods to omit {{\-> None}} return type annotations, but pytype has no such feature. I think we should include {{\-> None}} annotations for pytype compatibility.
> cc: [~chadrik]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)