You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@freestoneinfotech.com> on 2017/04/21 08:59:58 UTC
Review Request 58607: RANGER-1490 : Increase size of sort_order
column of x_policy_resource_map
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58607/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1490
https://issues.apache.org/jira/browse/RANGER-1490
Repository: ranger
Description
-------
**Problem Statement :** Currently data type of sort_order column is tinyint which can accept maximum 128 unsigned number; if any policy is having more than 128 resource entries then data truncation error might be generated at DB end and application will not be able to insert entry of any more resources for specific policy.
**Proposed Solution :** Change data type of sort_order column of 'x_policy_resource_map' from tinyint to integer(4 byte)
Diffs
-----
security-admin/db/mysql/patches/027-sortorder-column-size.sql PRE-CREATION
security-admin/db/oracle/patches/027-sortorder-column-size.sql PRE-CREATION
security-admin/db/postgres/patches/027-sortorder-column-size.sql PRE-CREATION
security-admin/db/sqlanywhere/patches/027-sortorder-column-size.sql PRE-CREATION
security-admin/db/sqlserver/patches/027-sortorder-column-size.sql PRE-CREATION
Diff: https://reviews.apache.org/r/58607/diff/1/
Testing
-------
**Steps Performed (with patch) :**
1. After mvn Build; untar the Ranger module and updated install.properties for MySQL DB flavor.
2. Called setup.sh to install Ranger.
**Expected Behavior :**
1. Ranger installation should finish successfully and patch 027 should get applied successfully.
2. Data type of sort_order column of x_policy_resource_map table should get change to 'int'
2. Ranger UI should work.
**Actual Behavior :**
1. Ranger Installtion finished successfully and patch 027 was applied successfully.
2. Data type of sort_order column of x_policy_resource_map table was changed to 'int'
2. Started Ranger Admin and was able to login in Ranger UI.
Note: Patch has been tested on all supported DB Flavors.
Thanks,
Pradeep Agrawal
Re: Review Request 58607: RANGER-1490 : Increase size of sort_order
column of x_policy_resource_map
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58607/#review172926
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On April 21, 2017, 8:59 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58607/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 8:59 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1490
> https://issues.apache.org/jira/browse/RANGER-1490
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement :** Currently data type of sort_order column is tinyint which can accept maximum 128 unsigned number; if any policy is having more than 128 resource entries then data truncation error might be generated at DB end and application will not be able to insert entry of any more resources for specific policy.
> **Proposed Solution :** Change data type of sort_order column of 'x_policy_resource_map' from tinyint to integer(4 byte)
>
>
> Diffs
> -----
>
> security-admin/db/mysql/patches/027-sortorder-column-size.sql PRE-CREATION
> security-admin/db/oracle/patches/027-sortorder-column-size.sql PRE-CREATION
> security-admin/db/postgres/patches/027-sortorder-column-size.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/027-sortorder-column-size.sql PRE-CREATION
> security-admin/db/sqlserver/patches/027-sortorder-column-size.sql PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58607/diff/1/
>
>
> Testing
> -------
>
> **Steps Performed (with patch) :**
> 1. After mvn Build; untar the Ranger module and updated install.properties for MySQL DB flavor.
> 2. Called setup.sh to install Ranger.
>
> **Expected Behavior :**
> 1. Ranger installation should finish successfully and patch 027 should get applied successfully.
> 2. Data type of sort_order column of x_policy_resource_map table should get change to 'int'
> 2. Ranger UI should work.
>
> **Actual Behavior :**
> 1. Ranger Installtion finished successfully and patch 027 was applied successfully.
> 2. Data type of sort_order column of x_policy_resource_map table was changed to 'int'
> 2. Started Ranger Admin and was able to login in Ranger UI.
>
> Note: Patch has been tested on all supported DB Flavors.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 58607: RANGER-1490 : Increase size of sort_order
column of x_policy_resource_map
Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58607/#review172917
-----------------------------------------------------------
Ship it!
Ship It!
- Ankita Sinha
On April 21, 2017, 8:59 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58607/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 8:59 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1490
> https://issues.apache.org/jira/browse/RANGER-1490
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement :** Currently data type of sort_order column is tinyint which can accept maximum 128 unsigned number; if any policy is having more than 128 resource entries then data truncation error might be generated at DB end and application will not be able to insert entry of any more resources for specific policy.
> **Proposed Solution :** Change data type of sort_order column of 'x_policy_resource_map' from tinyint to integer(4 byte)
>
>
> Diffs
> -----
>
> security-admin/db/mysql/patches/027-sortorder-column-size.sql PRE-CREATION
> security-admin/db/oracle/patches/027-sortorder-column-size.sql PRE-CREATION
> security-admin/db/postgres/patches/027-sortorder-column-size.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/027-sortorder-column-size.sql PRE-CREATION
> security-admin/db/sqlserver/patches/027-sortorder-column-size.sql PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58607/diff/1/
>
>
> Testing
> -------
>
> **Steps Performed (with patch) :**
> 1. After mvn Build; untar the Ranger module and updated install.properties for MySQL DB flavor.
> 2. Called setup.sh to install Ranger.
>
> **Expected Behavior :**
> 1. Ranger installation should finish successfully and patch 027 should get applied successfully.
> 2. Data type of sort_order column of x_policy_resource_map table should get change to 'int'
> 2. Ranger UI should work.
>
> **Actual Behavior :**
> 1. Ranger Installtion finished successfully and patch 027 was applied successfully.
> 2. Data type of sort_order column of x_policy_resource_map table was changed to 'int'
> 2. Started Ranger Admin and was able to login in Ranger UI.
>
> Note: Patch has been tested on all supported DB Flavors.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>