You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Vadim Gritsenko (JIRA)" <xa...@xml.apache.org> on 2005/09/26 19:26:51 UTC
[jira] Created: (XALANJ-2206) [PATCH] Propagate template inlining trax attribute
[PATCH] Propagate template inlining trax attribute
--------------------------------------------------
Key: XALANJ-2206
URL: http://issues.apache.org/jira/browse/XALANJ-2206
Project: XalanJ2
Type: Bug
Components: XSLTC
Versions: 2.7
Environment: trax, command line is not affected
Reporter: Vadim Gritsenko
Template inlining attribute set on xsltc TransformerFactoryImpl has no effect, default value from Stylesheet is always used. Attached patch resolves this issue.
This is required in order to use large stylesheets (such as where applyTemplates method with template inlining is over 64Kb).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Assigned: (XALANJ-2206) [PATCH] Propagate template inlining
trax attribute
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANJ-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Minchau reassigned XALANJ-2206:
-------------------------------------
Assignee: Brian Minchau (was: Yash Talwar)
> [PATCH] Propagate template inlining trax attribute
> --------------------------------------------------
>
> Key: XALANJ-2206
> URL: https://issues.apache.org/jira/browse/XALANJ-2206
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: 2.7
> Environment: trax, command line is not affected
> Reporter: Vadim Gritsenko
> Assignee: Brian Minchau
> Attachments: inlining-patch.diff
>
>
> Template inlining attribute set on xsltc TransformerFactoryImpl has no effect, default value from Stylesheet is always used. Attached patch resolves this issue.
> This is required in order to use large stylesheets (such as where applyTemplates method with template inlining is over 64Kb).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Resolved: (XALANJ-2206) [PATCH] Propagate template inlining
trax attribute
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANJ-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Minchau resolved XALANJ-2206.
-----------------------------------
Resolution: Fixed
Fix Version/s: The Latest Development Code
Problem fixed. I committed the fix to the main development code branch, and it will shortly make it under 2.7.1 as well.
> [PATCH] Propagate template inlining trax attribute
> --------------------------------------------------
>
> Key: XALANJ-2206
> URL: https://issues.apache.org/jira/browse/XALANJ-2206
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: 2.7
> Environment: trax, command line is not affected
> Reporter: Vadim Gritsenko
> Assignee: Brian Minchau
> Fix For: The Latest Development Code
>
> Attachments: inlining-patch.diff, xalanj-2206.inlining-patch4.txt
>
>
> Template inlining attribute set on xsltc TransformerFactoryImpl has no effect, default value from Stylesheet is always used. Attached patch resolves this issue.
> This is required in order to use large stylesheets (such as where applyTemplates method with template inlining is over 64Kb).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2206) [PATCH] Propagate template inlining
trax attribute
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANJ-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528894 ]
Brian Minchau commented on XALANJ-2206:
---------------------------------------
Actually Yash punted the problem to another committer, but the ball bounced off them and I'm catching it before it falls on the ground.
I have some review comments on the patch so far:
Basically good so far.
Curious that the patch gets rid of a few new Boolean(true) sort of things and replaces them
with Boolean.TRUE, which is a good thing, ... but then the patch goes on to add this in TransformerFactoryImpl:
return new Boolean(_enableInling)
rather than this:
if (_enableInlining)
return Boolean.TRUE;
else
return Boolean.FALSE;
Minor stuff over all. A bit more review of mine needed before I approve/commit a slightly modified version of the patch.
> [PATCH] Propagate template inlining trax attribute
> --------------------------------------------------
>
> Key: XALANJ-2206
> URL: https://issues.apache.org/jira/browse/XALANJ-2206
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: 2.7
> Environment: trax, command line is not affected
> Reporter: Vadim Gritsenko
> Assignee: Brian Minchau
> Attachments: inlining-patch.diff
>
>
> Template inlining attribute set on xsltc TransformerFactoryImpl has no effect, default value from Stylesheet is always used. Attached patch resolves this issue.
> This is required in order to use large stylesheets (such as where applyTemplates method with template inlining is over 64Kb).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2206) [PATCH] Propagate template inlining
trax attribute
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANJ-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527163 ]
Brian Minchau commented on XALANJ-2206:
---------------------------------------
Yash is going to look at this one. If OK it should make the 2.7.1 release, but this will probably be the last fix in the door for that release. - Brian
> [PATCH] Propagate template inlining trax attribute
> --------------------------------------------------
>
> Key: XALANJ-2206
> URL: https://issues.apache.org/jira/browse/XALANJ-2206
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: 2.7
> Environment: trax, command line is not affected
> Reporter: Vadim Gritsenko
> Assignee: Yash Talwar
> Attachments: inlining-patch.diff
>
>
> Template inlining attribute set on xsltc TransformerFactoryImpl has no effect, default value from Stylesheet is always used. Attached patch resolves this issue.
> This is required in order to use large stylesheets (such as where applyTemplates method with template inlining is over 64Kb).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Assigned: (XALANJ-2206) [PATCH] Propagate template inlining trax attribute
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2206?page=all ]
Brian Minchau reassigned XALANJ-2206:
-------------------------------------
Assign To: Yash Talwar
Assiging to Yash T., per the JIRA meeting on Nov. 1, 2005
> [PATCH] Propagate template inlining trax attribute
> --------------------------------------------------
>
> Key: XALANJ-2206
> URL: http://issues.apache.org/jira/browse/XALANJ-2206
> Project: XalanJ2
> Type: Bug
> Components: XSLTC
> Versions: 2.7
> Environment: trax, command line is not affected
> Reporter: Vadim Gritsenko
> Assignee: Yash Talwar
> Attachments: inlining-patch.diff
>
> Template inlining attribute set on xsltc TransformerFactoryImpl has no effect, default value from Stylesheet is always used. Attached patch resolves this issue.
> This is required in order to use large stylesheets (such as where applyTemplates method with template inlining is over 64Kb).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2206) [PATCH] Propagate template inlining
trax attribute
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2206?page=comments#action_12442921 ]
Brian Minchau commented on XALANJ-2206:
---------------------------------------
Per the JIRA meeting on Oct 16, 2005, Yash has agreed to look at this one again.
> [PATCH] Propagate template inlining trax attribute
> --------------------------------------------------
>
> Key: XALANJ-2206
> URL: http://issues.apache.org/jira/browse/XALANJ-2206
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: 2.7
> Environment: trax, command line is not affected
> Reporter: Vadim Gritsenko
> Assigned To: Yash Talwar
> Attachments: inlining-patch.diff
>
>
> Template inlining attribute set on xsltc TransformerFactoryImpl has no effect, default value from Stylesheet is always used. Attached patch resolves this issue.
> This is required in order to use large stylesheets (such as where applyTemplates method with template inlining is over 64Kb).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2206) [PATCH] Propagate template inlining
trax attribute
Posted by "Vadim Gritsenko (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANJ-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518706 ]
Vadim Gritsenko commented on XALANJ-2206:
-----------------------------------------
So Brian, was Yash able to do it? :)
> [PATCH] Propagate template inlining trax attribute
> --------------------------------------------------
>
> Key: XALANJ-2206
> URL: https://issues.apache.org/jira/browse/XALANJ-2206
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: 2.7
> Environment: trax, command line is not affected
> Reporter: Vadim Gritsenko
> Assignee: Yash Talwar
> Attachments: inlining-patch.diff
>
>
> Template inlining attribute set on xsltc TransformerFactoryImpl has no effect, default value from Stylesheet is always used. Attached patch resolves this issue.
> This is required in order to use large stylesheets (such as where applyTemplates method with template inlining is over 64Kb).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org