You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/08/16 11:16:29 UTC
[GitHub] [iotdb] JianyunCheng opened a new pull request #3755: [IOTDB-1473] Fix the bug that run SessionExample.java will be failed
JianyunCheng opened a new pull request #3755:
URL: https://github.com/apache/iotdb/pull/3755
JIRA issue: https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-1473
The issue happens because auto create schema doesn't work in cluster mode. The insertTables() tries to insert timeseries to `root.sg1.d2.s1`, `root.sg1.d2.s2`, `root.sg1.d2.s3` but which aren't created until the insertion. The schema create logic fail in the execution path which cause the issue.
Actually, there are three errors of the auto create schema fail in the cluster as far as I can know (comment out the create timeseries related code in `SessionExample.java`).
```
...
// createTimeseries();
// createMultiTimeseries();
// insertRecord();
insertTablet(); // can't auto creating schema
insertTablets(); // can't auto creating schema
insertRecords(); // can't auto creating schema
selectInto();
.....
```
This PR fixed the first two of situations. Has filed a [JIRA issue](https://issues.apache.org/jira/browse/IOTDB-1570) to track the third situation which need some more discussion.
### Fix logic
`insertTablet()` fails because this kind of insertion will call `forwardMultiSubPlan()` which will return a wrapper result instead of 304 error directly which cause the error handling logic doesn't work.
For `insertTablets()`, it also need to apply measurements according to failed measurements for all sub `insertTablet()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #3755: [IOTDB-1473] Fix the bug that run SessionExample.java will be failed
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on pull request #3755:
URL: https://github.com/apache/iotdb/pull/3755#issuecomment-899930934
you need perform "mvn spotless:apply"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 closed pull request #3755: [IOTDB-1473] Fix the bug that run SessionExample.java will be failed
Posted by GitBox <gi...@apache.org>.
wangchao316 closed pull request #3755:
URL: https://github.com/apache/iotdb/pull/3755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] chengjianyun commented on pull request #3755: [IOTDB-1473] Fix the bug that run SessionExample.java will be failed
Posted by GitBox <gi...@apache.org>.
chengjianyun commented on pull request #3755:
URL: https://github.com/apache/iotdb/pull/3755#issuecomment-900190663
Hi, there
The PR should be abandoned. I have submitted a new PR https://github.com/apache/iotdb/pull/3770 to replace this one. Sorry for the inconvenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3755: [IOTDB-1473] Fix the bug that run SessionExample.java will be failed
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3755:
URL: https://github.com/apache/iotdb/pull/3755#issuecomment-899451554
[](https://coveralls.io/builds/42168796)
Coverage increased (+0.003%) to 67.231% when pulling **9c5c2a45090be4086fd6bd003b63d5000496f7d2 on chengjianyun:bugfix/cluster-auto-schema** into **7ea4f0d6d71bcb72b1e21a5684fdb79ae82707b4 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] chengjianyun commented on pull request #3755: [IOTDB-1473] Fix the bug that run SessionExample.java will be failed
Posted by GitBox <gi...@apache.org>.
chengjianyun commented on pull request #3755:
URL: https://github.com/apache/iotdb/pull/3755#issuecomment-900062881
Please help close the PR as it doesn't fix the bug clearly. I will start a discussion to talk about the auto schema creating feature. @wangchao316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] chengjianyun commented on pull request #3755: [IOTDB-1473] Fix the bug that run SessionExample.java will be failed
Posted by GitBox <gi...@apache.org>.
chengjianyun commented on pull request #3755:
URL: https://github.com/apache/iotdb/pull/3755#issuecomment-899962655
> you need perform "mvn spotless:apply"
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3755: [IOTDB-1473] Fix the bug that run SessionExample.java will be failed
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3755:
URL: https://github.com/apache/iotdb/pull/3755#issuecomment-899451554
[](https://coveralls.io/builds/42192394)
Coverage decreased (-0.006%) to 67.264% when pulling **d9d7b04dbc7224a09a4ecefd4cfa3c57e1dd49f4 on chengjianyun:bugfix/cluster-auto-schema** into **9d21b207df77f0297457fe3fa137d0dd79cd8dd6 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 removed a comment on pull request #3755: [IOTDB-1473] Fix the bug that run SessionExample.java will be failed
Posted by GitBox <gi...@apache.org>.
wangchao316 removed a comment on pull request #3755:
URL: https://github.com/apache/iotdb/pull/3755#issuecomment-899930934
you need perform "mvn spotless:apply"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] chengjianyun edited a comment on pull request #3755: [IOTDB-1473] Fix the bug that run SessionExample.java will be failed
Posted by GitBox <gi...@apache.org>.
chengjianyun edited a comment on pull request #3755:
URL: https://github.com/apache/iotdb/pull/3755#issuecomment-900190663
Hi, there
The PR should be **abandoned**. I have submitted a new PR https://github.com/apache/iotdb/pull/3770 to replace this one. Sorry for the inconvenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org