You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/14 08:55:34 UTC

[GitHub] [arrow-datafusion] ygf11 commented on pull request #4193: Support normal expressions in equality join

ygf11 commented on PR #4193:
URL: https://github.com/apache/arrow-datafusion/pull/4193#issuecomment-1313310353

   Thank you @mingmwang.
   
   > Not sure whether the two methods can be combined or not.
   
   The `extract_join_keys` is used to generate explicit join plan, and the `extract_possible_join_keys` is used to optimize `selection clause` from `cross join` to `inner join`.
   
   I think the logic of generating two join plan are similar, so we can try to combine them next.
   
   > From my understanding, I think the extract process should be
   
   Yes, you are right. The first two was done by original `extract_join_keys`, and I add the three to `extract_join_keys` in this pr.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org