You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sunank200 (via GitHub)" <gi...@apache.org> on 2025/07/03 16:14:43 UTC
[PR] Move all BaseHook usages to version_compat in Datadog [airflow]
sunank200 opened a new pull request, #52801:
URL: https://github.com/apache/airflow/pull/52801
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Part of https://github.com/apache/airflow/issues/52676
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #52801:
URL: https://github.com/apache/airflow/pull/52801#issuecomment-3038833000
> I can see it as well, it has a 20% failure rate.
>
> I'm investigating it. I might end up marking the tests with `xfail` until I come up with a permanent solution.
>
Might be a good approach - if so -> create an issue and I wiil assign it to the "flaky stuff" board in https://github.com/orgs/apache/projects/403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #52801:
URL: https://github.com/apache/airflow/pull/52801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #52801:
URL: https://github.com/apache/airflow/pull/52801#issuecomment-3035196798
I am investigating as to why redis tests are sometimes failing..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "xBis7 (via GitHub)" <gi...@apache.org>.
xBis7 commented on PR #52801:
URL: https://github.com/apache/airflow/pull/52801#issuecomment-3036467389
@potiuk Can you determine approximately how ofter does the test fail? Is it too often? e.g. 50% of the runs?
I thought I fixed the flakiness because I ran the CI at least 10 times without errors. I'll look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #52801:
URL: https://github.com/apache/airflow/pull/52801#issuecomment-3035204391
> I am investigating as to why redis tests are sometimes failing..
Yeah. I saw that too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #52801:
URL: https://github.com/apache/airflow/pull/52801#issuecomment-3038112260
@xBis7 do not have exact numbers but I can share some occurrences with you that could help.
- https://github.com/apache/airflow/actions/runs/16056316701/job/45311945337?pr=52801
- https://github.com/apache/airflow/actions/runs/16056705241/job/45313296467?pr=52814
And few more, some of these have occurred more than once on the same pr. So it's not a one-off case, needs investigating and fixing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "xBis7 (via GitHub)" <gi...@apache.org>.
xBis7 commented on PR #52801:
URL: https://github.com/apache/airflow/pull/52801#issuecomment-3038857362
https://github.com/apache/airflow/issues/52906
@potiuk Can you modify it to add the correct labels?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #52801:
URL: https://github.com/apache/airflow/pull/52801#issuecomment-3035225038
@xBis7 -> seems your latest change introduced some flakines in scenario in this "foreceful" stop test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "xBis7 (via GitHub)" <gi...@apache.org>.
xBis7 commented on PR #52801:
URL: https://github.com/apache/airflow/pull/52801#issuecomment-3038869605
> Done.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #52801:
URL: https://github.com/apache/airflow/pull/52801#issuecomment-3038866378
> @potiuk Can you modify it to add the correct labels?
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move all BaseHook usages to version_compat in Datadog [airflow]
Posted by "xBis7 (via GitHub)" <gi...@apache.org>.
xBis7 commented on PR #52801:
URL: https://github.com/apache/airflow/pull/52801#issuecomment-3038813931
I can see it as well, it has a 20% failure rate.
I'm investigating it. I might end up marking the tests with `xfail` until I come up with a permanent solution.
https://github.com/xBis7/airflow/actions/runs/16086980198
https://github.com/xBis7/airflow/actions/runs/16087424463
https://github.com/xBis7/airflow/actions/runs/16087596566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org