[GitHub] brooklyn-dist pull request #114: Fix brooklyn-dist (classic) build

[aledsage <gi...@git.apache.org>]

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-dist/pull/114

    Fix brooklyn-dist (classic) build

    This fixes the build for `brooklyn-dist` (i.e. for brooklyn classic mode). I broke it in https://github.com/apache/brooklyn-server/pull/886 when I deleted its `catalog.bom` - this project tries to find that .bom file in mvn! Things seemed to work because local .m2 maven snapshot repos had the old version of that file, but it would fail on a clean machine.
    
    Note that `brooklyn-dist` was crippled by https://github.com/apache/brooklyn-server/pull/882 - that stripped out most things from the brooklyn-cli catalog.bom (by removing `scanJavaAnnotations: true`) so the classic dist only had 4 things in its catalog rather than everything it could find during a scan.
    
    This PR's default.catalog.bom is a copy of the file from before https://github.com/apache/brooklyn-server/pull/882.
    
    Also note that we actually want to delete this whole project - we don't want brooklyn classic mode in the 1.0.0! But we need to first check if it contains anything else important (unrelated to classic) - for example, it contains https://github.com/apache/brooklyn-dist/tree/master/dist/licensing. Not sure where we can move that to, such that the license generation will still work @ahgittin?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-dist fix-classic-dist-build

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-dist/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #114
    
----
commit 7f3ea2d143e2643b44149b8d22d55a709934eb95
Author: Aled Sage <al...@gmail.com>
Date:   2017-11-10T18:35:26Z

    Fix brooklyn-dist (classic) build

----


---

[GitHub] brooklyn-dist pull request #114: Fix brooklyn-dist (classic) build

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-dist/pull/114


---