You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/09 10:30:50 UTC
[GitHub] [iceberg] foarsitter opened a new pull request, #6158: Python: CI poetry cache
foarsitter opened a new pull request, #6158:
URL: https://github.com/apache/iceberg/pull/6158
The `setup-python@v4` action supports caching for poetry lock files as shown over here: https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#caching-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] foarsitter commented on a diff in pull request #6158: Python: CI poetry cache
Posted by GitBox <gi...@apache.org>.
foarsitter commented on code in PR #6158:
URL: https://github.com/apache/iceberg/pull/6158#discussion_r1017838716
##########
.github/workflows/python-ci.yml:
##########
@@ -43,9 +43,14 @@ jobs:
steps:
- uses: actions/checkout@v3
+ - name: Install poetry
+ run: pip install poetry
Review Comment:
I'm not a fan of pinning development requirements unless you have information it will break anyway. This way the CI will learn us when Poetry isn't backwards compatible anymore.
Remember to pin Poetry in the Makefile if decide to stick to a certain Poetry verison https://github.com/apache/iceberg/blob/abcc65b4f2e25dc9830cf0def907540fe15f5f76/python/Makefile#L19 also.
##########
.github/workflows/python-ci.yml:
##########
@@ -43,9 +43,14 @@ jobs:
steps:
- uses: actions/checkout@v3
+ - name: Install poetry
+ run: pip install poetry
Review Comment:
I'm not a fan of pinning development requirements unless you have information it will break anyway. This way the CI will learn us when Poetry isn't backwards compatible anymore.
Remember to pin Poetry in the Makefile if decide to stick to a certain Poetry verison https://github.com/apache/iceberg/blob/abcc65b4f2e25dc9830cf0def907540fe15f5f76/python/Makefile#L19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #6158: Python: CI poetry cache
Posted by GitBox <gi...@apache.org>.
Fokko merged PR #6158:
URL: https://github.com/apache/iceberg/pull/6158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #6158: Python: CI poetry cache
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #6158:
URL: https://github.com/apache/iceberg/pull/6158#issuecomment-1308669435
Thanks @foarsitter ! 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko closed pull request #6158: Python: CI poetry cache
Posted by GitBox <gi...@apache.org>.
Fokko closed pull request #6158: Python: CI poetry cache
URL: https://github.com/apache/iceberg/pull/6158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #6158: Python: CI poetry cache
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #6158:
URL: https://github.com/apache/iceberg/pull/6158#issuecomment-1308551127
Thanks for working on this @foarsitter, this is awesome! Looks like the CI is a little sad because it expects `poetry` to be already installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #6158: Python: CI poetry cache
Posted by GitBox <gi...@apache.org>.
Fokko commented on code in PR #6158:
URL: https://github.com/apache/iceberg/pull/6158#discussion_r1017798337
##########
.github/workflows/python-ci.yml:
##########
@@ -43,9 +43,14 @@ jobs:
steps:
- uses: actions/checkout@v3
+ - name: Install poetry
+ run: pip install poetry
Review Comment:
Should we pin Poetry on a version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org