[GitHub] [incubator-iceberg] rominparekh commented on a change in pull request #117: Sorts bin packing by weights in descending order

[GitBox <gi...@apache.org>]

rominparekh commented on a change in pull request #117: Sorts bin packing by weights in descending order
URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r263689348
 
 

 ##########
 File path: core/src/main/java/com/netflix/iceberg/util/BinPacking.java
 ##########
 @@ -144,6 +148,10 @@ public void add(T item, long weight) {
         this.binWeight += weight;
         items.add(item);
       }
+
+      public long getWeight() {
 
 Review comment:
   +1 thanks. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org