You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2017/07/10 19:29:18 UTC
[13/14] tinkerpop git commit: TINKERPOP-1698 Cleaned up comments
TINKERPOP-1698 Cleaned up comments
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/207cc342
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/207cc342
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/207cc342
Branch: refs/heads/master
Commit: 207cc342abf5e1ca0c85328ceeafde07afa32498
Parents: 98b7ffa
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Thu Jun 29 11:14:10 2017 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Mon Jul 10 14:14:03 2017 -0400
----------------------------------------------------------------------
.../gremlin/structure/io/gryo/GryoSerializersV3d0.java | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/207cc342/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoSerializersV3d0.java
----------------------------------------------------------------------
diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoSerializersV3d0.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoSerializersV3d0.java
index 82fa178..8a57a06 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoSerializersV3d0.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoSerializersV3d0.java
@@ -78,8 +78,10 @@ public final class GryoSerializersV3d0 {
// temporary try/catch perhaps? need this to get SparkSingleIterationStrategyTest to work. Trying to grab
// the label of the adjacent vertex ends in error if there's a StarEdge in the ComputerGraph$ComputerEdge.
- // maybe this gets fixed up when TINKERPOP-1592 is in play. hopefully this serializer will get better
- // with that
+ // apparently this is how we handle things in DetachedElement. i'll write here in the comments what was
+ // written there:
+ //
+ // ghetto
try {
output.writeString(edge.inVertex().label());
} catch (Exception ex) {
@@ -88,10 +90,7 @@ public final class GryoSerializersV3d0 {
kryo.writeClassAndObject(output, edge.outVertex().id());
- // temporary try/catch perhaps? need this to get SparkSingleIterationStrategyTest to work. Trying to grab
- // the label of the adjacent vertex ends in error if there's a StarEdge in the ComputerGraph$ComputerEdge.
- // maybe this gets fixed up when TINKERPOP-1592 is in play. hopefully this serializer will get better
- // with that
+ // same nonsense as above for a default label
try {
output.writeString(edge.outVertex().label());
} catch (Exception ex) {