[GitHub] dianfu opened a new pull request #7626: [FLINK-11450][table] Port and move TableSource and TableSink to flink-table-common

[GitBox <gi...@apache.org>]

dianfu opened a new pull request #7626: [FLINK-11450][table] Port and move TableSource and TableSink to flink-table-common
URL: https://github.com/apache/flink/pull/7626
 
 
   ## What is the purpose of the change
   
   *This pull request ported the following classes to flink-table-common:
      TableSource, TableSink, TableSinkBase, DefinedFieldMapping, NestedFieldsProjectableTableSource, ProjectableTableSource, TableConnectorUtil, ExternalCatalog, ExternalCatalogTable, Metadata, MetadataValidator, Schema, SchematicDescriptor, Statistics, StatisticsValidator, StreamTableDescriptorValidator, StreamableDescriptor, TableDescriptor, ColumnStats, TableStats*
   
   ## Brief change log
   
     - *Ported source/sink related classes to flink-table-common: TableSource, TableSink, TableSinkBase, DefinedFieldMapping, NestedFieldsProjectableTableSource, ProjectableTableSource, TableConnectorUtil*
     - *Ported ExternalCatalog to flink-table-common and also the classes it depends on:  ExternalCatalogTable, Metadata, MetadataValidator, Schema, SchematicDescriptor, Statistics, StatisticsValidator, StreamTableDescriptorValidator, StreamableDescriptor, TableDescriptor, ColumnStats, TableStats, TableNotExistException, CatalogNotExistException*
     - *Ported the tests to flink-table-common*
   
   The following things should be noted:
     - *The package name of TableConnectorUtil is changed from util to utils as there is a utils package in flink-table-common. Just create a util package for backward compatibility. Not sure if this is needed?*
     - *The interface of Schema.rowtime is changed as it depends on Rowtime which cannot be moved to flink-table-common for the time being as Rowtime depends on Expression*
     - *The constants variables are copied from SchemeValidator to Scheme as they are needed by Scheme, but SchemeValidator cannot be moved to flink-table-common for the time being. Have not moved these constants directly to Schema as I noticed all the constants are defined in Validator classes*
     - *StreamableDescriptor don't extends TableDescriptor anymore as otherwise it cannot be defined as an interface any more. *
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services