You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/03/15 19:37:34 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3983: ARTEMIS-3720 Max Number Of Messages on a deciding policy for paging (global and address-settings)

clebertsuconic commented on a change in pull request #3983:
URL: https://github.com/apache/activemq-artemis/pull/3983#discussion_r827345821



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##########
@@ -213,6 +213,8 @@
 
    private static final String MAX_SIZE_BYTES_NODE_NAME = "max-size-bytes";
 
+   private static final String MAX_MESSAGES_NODE_NAME = "max-messages";

Review comment:
       I thought about that..
   
   
   I thought that number of messages would not be a size thing... (quantity versus size)..
   
   If you think the term size would be okay here I can definitely include it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org