You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/09/28 14:16:19 UTC
[GitHub] [maven] cstamas opened a new pull request #555: Fix G level metadata handling
cstamas opened a new pull request #555:
URL: https://github.com/apache/maven/pull/555
Just make Resolver handle it. This is TBD, as actual
prefix still needs somehow to get there.
Notices:
- delegates all the work to Resolver (no need for tricks in m-a-t, m-d-p etc)
- removes m-p-p `addPluginArtifactMetadata` as it is not needed
- prefix needs to get here somehow (worst case: get it from effective model)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
mthmulders commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929533119
> @mthmulders this is a fix for Maven 4, but not for Maven 3
I don't think the fix that @MartinKanters and I have worked on is compatible with this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
mthmulders commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929327104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
mthmulders commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929506225
> > How does this relate to [MNG-7055](https://issues.apache.org/jira/browse/MNG-7055)?
>
> Fixes it (not yet, once done)
I'm a bit sad that the work that @MartinKanters and me had done so far (announced [in the JIRA ticket](https://issues.apache.org/jira/browse/MNG-7055?focusedCommentId=17379009&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17379009) and more recently [here on GitHub](https://github.com/apache/maven/pull/552#issuecomment-927659381)) is apparently of no use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929498496
A similar change needs to be done for both plugins, in case it is used with Maven 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
mthmulders commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929327104
How does this relate to [MNG-7055](https://issues.apache.org/jira/browse/MNG-7055)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929388619
> How does this relate to [MNG-7055](https://issues.apache.org/jira/browse/MNG-7055)?
Fixes it (not yet, once done)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #555: [MNG-7055] Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
cstamas merged pull request #555:
URL: https://github.com/apache/maven/pull/555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929388619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929498496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929525155
@mthmulders this is a fix for Maven 4, but not for Maven 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929480338
The ITs reported in MNG-7055 to fail with 3.x of m-install-p and m-deploy-p are passing OK (!), but now another IT fails:
```
[INFO]
[INFO] Results:
[INFO]
Error: Failures:
Error: MavenIT0138PluginLifecycleTest>AbstractMavenIntegrationTestCase.runTest:265->testit0138:60 Expected file was not found: /home/runner/work/maven/maven/maven-integration-testing/core-it-suite/target/test-classes/it0138/target/plugin-add-plugin-artifact-metadata.txt
[INFO]
Error: Tests run: 882, Failures: 1, Errors: 0, Skipped: 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #555: Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-929494607
Patched ITs with https://github.com/apache/maven-integration-testing/pull/114 all pass OK:
```
[INFO] Tests run: 879, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 192.019 s - in org.apache.maven.it.IntegrationTestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 879, Failures: 0, Errors: 0, Skipped: 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #555: [MNG-7055] Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-931316580
Does this mean that the `AddPluginArtifactMetadataMojo` from maven-plugin-plugin is completely useless ? This is actually one of the pain point because it depends on the `GroupRepositoryMetadata` which is in maven-compat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #555: [MNG-7055] Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-932179976
Related to https://github.com/apache/maven-plugin-tools/pull/37 wrt `GroupRepositoryMetadata` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #555: [MNG-7055] Fix G level metadata handling
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-931320282
> Does this mean that the `AddPluginArtifactMetadataMojo` from maven-plugin-plugin is completely useless ? This is actually one of the pain point because it depends on the `GroupRepositoryMetadata` which is in maven-compat.
Yes and no: Yes, as _we could_ get the only missing piece even without it (the goalPrefix that is plugin configuration). The "price" would be high, go thru plugin config/DOM stuff.... No, as due that above, it made this PR stupid simple (just reuse the data that mojo gave to us).
In general (and that's why I created this PR initially to drop this useless mojo) I'd drop it, but this seems like "simple first step", and later we can change it at will. Given m-plugin-p is "just a plugin" but is still quite often referenced in core (so somewhat not "just a plugin"), I think we could do more here, for example change the mojo to just stick some values somewhere (ie. session) and alter the provider in maven core and voila, GroupRepositoryMetadata is not needed....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org