You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/26 02:48:35 UTC
[GitHub] [spark] HyukjinKwon commented on issue #25008: [SPARK-28213][SQL]
Replace ColumnarBatchScan with equivilant from Columnar
HyukjinKwon commented on issue #25008: [SPARK-28213][SQL] Replace ColumnarBatchScan with equivilant from Columnar
URL: https://github.com/apache/spark/pull/25008#issuecomment-515287815
Hey, I see roughly the core logic itself is deduplicated fine without changing the exiting codes itself but seems like it changes the other stuff.
Let's be clear on what this PR fixes next time - I thought this was just a simple refactoring but now realised that this is actually pretty invasive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org