You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/09 06:00:18 UTC

[GitHub] [incubator-superset] ktmud commented on a change in pull request #11970: feat: add hook for dataset health check

ktmud commented on a change in pull request #11970:
URL: https://github.com/apache/incubator-superset/pull/11970#discussion_r539031961



##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.jsx
##########
@@ -139,6 +139,10 @@ class ControlPanelsContainer extends React.Component {
           controls[s].validationErrors.length > 0,
       ),
     );
+    if (exploreState.dataset_health_check_message) {

Review comment:
       This component `ControlPanelsContainer` is generic and should stay generic. It should not contain logics related to any specific control field.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org