You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by hsn10 <gi...@git.apache.org> on 2014/09/14 15:00:54 UTC
[GitHub] spark pull request: allow symlinking to shell scripts
GitHub user hsn10 opened a pull request:
https://github.com/apache/spark/pull/2386
allow symlinking to shell scripts
patch for SPARK-3482
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsn10/spark spark-3482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2386.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2386
----
commit cbee6c1ed46aea6c465aaabbf0b2f0635389a6a6
Author: Radim Kolar <hs...@sendmail.cz>
Date: 2014-09-14T12:49:25Z
allow symlinking to shell scripts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: allow symlinking to shell scripts
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2386#issuecomment-55526164
Again, still looks like a duplicate of https://github.com/apache/spark/pull/1875
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: allow symlinking to shell scripts
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/2386#discussion_r17530408
--- Diff: bin/spark-shell ---
@@ -29,7 +29,7 @@ esac
set -o posix
## Global script variables
-FWDIR="$(cd "`dirname "$0"`"/..; pwd)"
+FWDIR="$(cd $(dirname $(readlink -f $0))/..; pwd)"
--- End diff --
You may have to quote these - so that dirs with spaces within their name work. Like they do at the moment.
Above should look like.
```FWDIR="$(cd "$(dirname "$(readlink -f "$0")")"/..; pwd)"```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: allow symlinking to shell scripts
Posted by roji <gi...@git.apache.org>.
Github user roji commented on the pull request:
https://github.com/apache/spark/pull/2386#issuecomment-57358006
Note that this PR won't support cases of symlink to symlink to Spark (i.e. multiple redirections). The PR I submitted at some point (#1875) shows how to implement this properly with a loop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: allow symlinking to shell scripts
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2386#issuecomment-65168822
Thanks for working on this, however, since its a duplicate I think we should probably close this issue and continue any discussion on #1875.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: allow symlinking to shell scripts
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2386#issuecomment-55524878
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: allow symlinking to shell scripts
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2386
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: allow symlinking to shell scripts
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/2386#discussion_r17530450
--- Diff: bin/spark-shell ---
@@ -29,7 +29,7 @@ esac
set -o posix
## Global script variables
-FWDIR="$(cd "`dirname "$0"`"/..; pwd)"
+FWDIR="$(cd $(dirname $(readlink -f $0))/..; pwd)"
--- End diff --
Ofcourse this applies to all other places as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org