You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/10 21:03:35 UTC
[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request #52: [FLINK-26574] Expose config files in helm chart
gyfora opened a new pull request #52:
URL: https://github.com/apache/flink-kubernetes-operator/pull/52
Main changes:
- Move the default config and logging properties to files from the helm templates
- Allow users to easily override operator and flink default configs from helm chart values
- Allow users to use easily use their own configmaps instead of ones created by helm
This PR should be merged only after https://github.com/apache/flink-kubernetes-operator/pull/51 as the config keys have already been adapted to that PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #52: [FLINK-26574] Expose config files in helm chart
Posted by GitBox <gi...@apache.org>.
morhidi commented on a change in pull request #52:
URL: https://github.com/apache/flink-kubernetes-operator/pull/52#discussion_r824731585
##########
File path: helm/flink-operator/values.yaml
##########
@@ -55,10 +55,32 @@ webhook:
# name: jks-password-secret
# key: password-key
-imagePullSecrets: []
-nameOverride: ""
-fullnameOverride: ""
+operatorConfiguration:
+ create: true
+ flink-conf.yaml: |+
+ metrics.reporter.slf4j.factory.class: org.apache.flink.metrics.slf4j.Slf4jReporterFactory
+ metrics.reporter.slf4j.interval: 5 MINUTE
+
+ operator.reconciler.reschedule.interval.sec: 15
+ operator.observer.progress-check.interval.sec: 5
+ log4j2.properties: |+
+ rootLogger.level = DEBUG
+ # Set append to false to replace configuration files
+ # append: true
Review comment:
Looks better :) I suggest to move this property under `create: true`. I missed it at first sight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #52: [FLINK-26574] Expose config files in helm chart
Posted by GitBox <gi...@apache.org>.
gyfora merged pull request #52:
URL: https://github.com/apache/flink-kubernetes-operator/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #52: [FLINK-26574] Expose config files in helm chart
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #52:
URL: https://github.com/apache/flink-kubernetes-operator/pull/52#issuecomment-1064503744
cc @morhidi @mbalassi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #52: [FLINK-26574] Expose config files in helm chart
Posted by GitBox <gi...@apache.org>.
morhidi commented on pull request #52:
URL: https://github.com/apache/flink-kubernetes-operator/pull/52#issuecomment-1064882839
Thank @gyfora, I'll play with this today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #52: [FLINK-26574] Expose config files in helm chart
Posted by GitBox <gi...@apache.org>.
morhidi commented on pull request #52:
URL: https://github.com/apache/flink-kubernetes-operator/pull/52#issuecomment-1064889825
We can also consider putting all the default config values in the values.yaml as is:
https://github.com/elastic/helm-charts/blob/d915d8d53721d7a0535b0956509c6a6e8756f3ec/elasticsearch/values.yaml#L31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #52: [FLINK-26574] Expose config files in helm chart
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #52:
URL: https://github.com/apache/flink-kubernetes-operator/pull/52#issuecomment-1065102721
@morhidi based on the feedback I made the following improvements:
Allow users to append-to or replace all config files (yaml and logging props) from values.
Default behaviour is append (to the default configs defined in the conf directories)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org