You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/08 12:38:27 UTC
[GitHub] [skywalking-infra-e2e] JohnNiang opened a new pull request #66: Fix the problem of paring verify.retry.interval without setting value
JohnNiang opened a new pull request #66:
URL: https://github.com/apache/skywalking-infra-e2e/pull/66
### What this PR dose?
Parse interval without setting value.
### Why we need it?
I have such an E2E testing requirement: we will only need to verify whether it is normal in `setup` phase. When I started with the following E2E configuration, I encountered an error like below:
**E2E configuration**:
```yaml
setup:
env: compose
file: docker-compose.yml
timeout: 20m
cleanup:
# always never success failure
on: always
```
**Partial error log**:
```bash
INFO no trigger need to execute
INFO deleting kind cluster...
Deleting cluster "kind" ...
INFO delete kind cluster succeeded
INFO deleting k8s cluster config file:/tmp/e2e-k8s.config
INFO cleanup part finished successfully
ERROR failed to parse verify.retry.interval: <nil>
Error: Process completed with exit code 1.
```
This PR tries to fix this problem of parsing `verify.retry.interval` with nil value. Especially we don't want a verification here.
Although the function `parseInterval` would be removed in `v2.0.0`, this solution could resolve this problem well now.
/kind bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu merged pull request #66: Fix the problem of paring verify.retry.interval without setting value
Posted by GitBox <gi...@apache.org>.
mrproliu merged pull request #66:
URL: https://github.com/apache/skywalking-infra-e2e/pull/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org