You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/06/05 19:13:23 UTC
[GitHub] [groovy] nineninesevenfour opened a new pull request #1590: conversion to collection: attach exception of constructor as suppressed exception
nineninesevenfour opened a new pull request #1590:
URL: https://github.com/apache/groovy/pull/1590
Proposed solution to https://issues.apache.org/jira/browse/GROOVY-7867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] nineninesevenfour commented on pull request #1590: GROOVY-7867: cast to collection: attach exception of constructor as suppressed exception
Posted by GitBox <gi...@apache.org>.
nineninesevenfour commented on pull request #1590:
URL: https://github.com/apache/groovy/pull/1590#issuecomment-877655321
@eric-milles
Thank you so much for your review! I did the requested changes. Honestly I have no idea why I made it unnecessarily complicated like this, it's much better now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1590: GROOVY-7867: cast to collection: attach exception of constructor as suppressed exception
Posted by GitBox <gi...@apache.org>.
eric-milles commented on pull request #1590:
URL: https://github.com/apache/groovy/pull/1590#issuecomment-874766107
Instead of stashing `ex` into `e` and then extracting in the `GroovyCastException` constructor, can you save the reference as a peer to the `nested` local variable and then call `addSuppressed` on the new cast exception instance? I can't really say how many places make use of the `GroovyCastException` constructor.
Also, you don't need a package statement for your test scripts. They should run just fine from the default package. Usually we add that only if there is a need to check a scenario involving separate packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] eric-milles merged pull request #1590: GROOVY-7867: cast to collection: attach exception of constructor as suppressed exception
Posted by GitBox <gi...@apache.org>.
eric-milles merged pull request #1590:
URL: https://github.com/apache/groovy/pull/1590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org