You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2015/09/24 00:46:30 UTC
Review Request 38695: Hive View does not support HS2 configured with
LDAP Auth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38695/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-13217
https://issues.apache.org/jira/browse/AMBARI-13217
Repository: ambari
Description (updated)
-------
Implemented LDAP authentication for HIVE view.
Diffs (updated)
-----
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java c30b269
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java 5a4406a
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveAuthCredentials.java PRE-CREATION
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveAuthRequiredException.java PRE-CREATION
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveClientAuthRequiredException.java PRE-CREATION
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/IConnectionFactory.java 7a3df06
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalConnection.java PRE-CREATION
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalHiveAuthCredentials.java PRE-CREATION
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java 55919a7
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java.orig PRE-CREATION
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java ad46e33
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java.orig PRE-CREATION
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/OperationHandleController.java 8156c29
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/OperationHandleControllerFactory.java 4297078
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobControllerFactory.java 12d1cdb
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobControllerImpl.java 32d64ec
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/SharedObjectsFactory.java df67985
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js e6bc7f1
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 2519df1
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/modal-save.js 6dc1349
contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 8f9f72d
contrib/views/hive/src/main/resources/ui/hive-web/app/routes/application.js 11b93a1
contrib/views/hive/src/main/resources/ui/hive-web/app/services/database.js 6b4df6f
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/modal-save.hbs f327e3b
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java 2b915f0
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/client/ConnectionTest.java PRE-CREATION
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/JobLDAPServiceTest.java PRE-CREATION
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/JobServiceTest.java 897d951
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java PRE-CREATION
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocalFactory.java PRE-CREATION
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ViewUserLocalTest.java c82df62
Diff: https://reviews.apache.org/r/38695/diff/
Testing (updated)
-------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.421 sec
Running org.apache.ambari.view.hive.client.ConnectionTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.388 sec
Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.598 sec
Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.069 sec
Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.162 sec
Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.87 sec
Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.905 sec
Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.213 sec
Running org.apache.ambari.view.hive.resources.files.FileServiceTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.358 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.735 sec
Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.609 sec
Running org.apache.ambari.view.hive.PropertyValidatorTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.109 sec
Results :
Tests run: 54, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ hive ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.gitattributes
[INFO] Exclude: .idea/
[INFO] Exclude: pass.txt
[INFO] Exclude: .DS_Store
[INFO] Exclude: .iml/
[INFO] Exclude: .classpath
[INFO] Exclude: .project
[INFO] Exclude: .settings
[INFO] Exclude: **/target/**
[INFO] Exclude: **/.gitkeep
[INFO] Exclude: **/.bowerrc
[INFO] Exclude: **/.editorconfig
[INFO] Exclude: **/.jshintrc
[INFO] Exclude: **/.tmp/**
[INFO] Exclude: **/tmp/**
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/bin
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/public/**
[INFO] Exclude: **/dist/**
[INFO] Exclude: **/bower_components/**
[INFO] Exclude: **/bower/**
[INFO] Exclude: **/node/**
[INFO] Exclude: **/runner.js
[INFO] Exclude: **/assets/javascripts/**
[INFO] Exclude: **/assets/stylesheets/**
[INFO] Exclude: **/assets/static/javascripts/**
[INFO] Exclude: **/assets/static/stylesheets/**
[INFO] Exclude: storm/src/main/resources/**
[INFO] 321 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Compiler warnings:
WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 320 licence.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ hive ---
[INFO] Building jar: /shared/submodules/ambari/contrib/views/hive/target/hive-1.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ hive ---
[INFO] Reading assembly descriptor: /shared/submodules/ambari/ambari-project/src/main/assemblies/empty.xml
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari View Utils .................................. SUCCESS [ 8.437 s]
[INFO] Hive ............................................... SUCCESS [ 42.402 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 51.272 s
[INFO] Finished at: 2015-09-23T22:43:39+00:00
[INFO] Final Memory: 68M/1202M
[INFO] ------------------------------------------------------------------------
Thanks,
Pallav Kulshreshtha
Re: Review Request 38695: Hive View does not support HS2 configured
with LDAP Auth
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38695/#review100320
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Sept. 23, 2015, 10:46 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38695/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 10:46 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-13217
> https://issues.apache.org/jira/browse/AMBARI-13217
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Implemented LDAP authentication for HIVE view.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java c30b269
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java 5a4406a
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveAuthCredentials.java PRE-CREATION
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveAuthRequiredException.java PRE-CREATION
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveClientAuthRequiredException.java PRE-CREATION
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/IConnectionFactory.java 7a3df06
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalConnection.java PRE-CREATION
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalHiveAuthCredentials.java PRE-CREATION
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java 55919a7
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java.orig PRE-CREATION
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java ad46e33
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java.orig PRE-CREATION
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/OperationHandleController.java 8156c29
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/OperationHandleControllerFactory.java 4297078
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobControllerFactory.java 12d1cdb
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobControllerImpl.java 32d64ec
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/SharedObjectsFactory.java df67985
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js e6bc7f1
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 2519df1
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/modal-save.js 6dc1349
> contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 8f9f72d
> contrib/views/hive/src/main/resources/ui/hive-web/app/routes/application.js 11b93a1
> contrib/views/hive/src/main/resources/ui/hive-web/app/services/database.js 6b4df6f
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/modal-save.hbs f327e3b
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java 2b915f0
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/client/ConnectionTest.java PRE-CREATION
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/JobLDAPServiceTest.java PRE-CREATION
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/JobServiceTest.java 897d951
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java PRE-CREATION
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocalFactory.java PRE-CREATION
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ViewUserLocalTest.java c82df62
>
> Diff: https://reviews.apache.org/r/38695/diff/
>
>
> Testing
> -------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.421 sec
> Running org.apache.ambari.view.hive.client.ConnectionTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.388 sec
> Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.598 sec
> Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.069 sec
> Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.162 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.87 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.905 sec
> Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.213 sec
> Running org.apache.ambari.view.hive.resources.files.FileServiceTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.358 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.735 sec
> Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.609 sec
> Running org.apache.ambari.view.hive.PropertyValidatorTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.109 sec
>
> Results :
>
> Tests run: 54, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ hive ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: **/.gitignore
> [INFO] Exclude: **/.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.gitkeep
> [INFO] Exclude: **/.bowerrc
> [INFO] Exclude: **/.editorconfig
> [INFO] Exclude: **/.jshintrc
> [INFO] Exclude: **/.tmp/**
> [INFO] Exclude: **/tmp/**
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.svg
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/bin
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/public/**
> [INFO] Exclude: **/dist/**
> [INFO] Exclude: **/bower_components/**
> [INFO] Exclude: **/bower/**
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/runner.js
> [INFO] Exclude: **/assets/javascripts/**
> [INFO] Exclude: **/assets/stylesheets/**
> [INFO] Exclude: **/assets/static/javascripts/**
> [INFO] Exclude: **/assets/static/stylesheets/**
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 321 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 320 licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ hive ---
> [INFO] Building jar: /shared/submodules/ambari/contrib/views/hive/target/hive-1.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ hive ---
> [INFO] Reading assembly descriptor: /shared/submodules/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari View Utils .................................. SUCCESS [ 8.437 s]
> [INFO] Hive ............................................... SUCCESS [ 42.402 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51.272 s
> [INFO] Finished at: 2015-09-23T22:43:39+00:00
> [INFO] Final Memory: 68M/1202M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>