You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Bill de hOra (JIRA)" <ji...@apache.org> on 2008/07/06 11:18:32 UTC
[jira] Created: (HADOOP-3697) Dependency cycle: log and mapred
Dependency cycle: log and mapred
--------------------------------
Key: HADOOP-3697
URL: https://issues.apache.org/jira/browse/HADOOP-3697
Project: Hadoop Core
Issue Type: Improvement
Components: mapred
Reporter: Bill de hOra
Priority: Minor
There's a dependency cycle between org.apache.hadoop.log and org.apache.hadoop.mapred. Moving the inner servlet class in LogLevel to StatusHttpServer fixes it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3697) Dependency cycle: log and mapred
Posted by "Bill de hOra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill de hOra updated HADOOP-3697:
---------------------------------
Status: Open (was: Patch Available)
you're right there's no cycle, my mistake. It's just that the log package doesn't seem to need to exist if LogLevel.Servlet is moved back into mapred (which is the only user in core).
> Dependency cycle: log and mapred
> --------------------------------
>
> Key: HADOOP-3697
> URL: https://issues.apache.org/jira/browse/HADOOP-3697
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Bill de hOra
> Priority: Minor
> Attachments: HADOOP-3697.patch
>
>
> There's a dependency cycle between org.apache.hadoop.log and org.apache.hadoop.mapred. Moving the inner servlet class in LogLevel to StatusHttpServer fixes it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3697) Dependency cycle: log and mapred
Posted by "Bill de hOra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill de hOra updated HADOOP-3697:
---------------------------------
Attachment: HADOOP-3697.patch
patch for issue
Inverts the dependency of LogLevel on mapred by moving its inner Servlet to StatusHttpServer
> Dependency cycle: log and mapred
> --------------------------------
>
> Key: HADOOP-3697
> URL: https://issues.apache.org/jira/browse/HADOOP-3697
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Bill de hOra
> Priority: Minor
> Attachments: HADOOP-3697.patch
>
>
> There's a dependency cycle between org.apache.hadoop.log and org.apache.hadoop.mapred. Moving the inner servlet class in LogLevel to StatusHttpServer fixes it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3697) Dependency cycle: log and mapred
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611894#action_12611894 ]
Hadoop QA commented on HADOOP-3697:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12385340/HADOOP-3697.patch
against trunk revision 675078.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2824/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2824/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2824/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2824/console
This message is automatically generated.
> Dependency cycle: log and mapred
> --------------------------------
>
> Key: HADOOP-3697
> URL: https://issues.apache.org/jira/browse/HADOOP-3697
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Bill de hOra
> Priority: Minor
> Attachments: HADOOP-3697.patch
>
>
> There's a dependency cycle between org.apache.hadoop.log and org.apache.hadoop.mapred. Moving the inner servlet class in LogLevel to StatusHttpServer fixes it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3697) Dependency cycle: log and mapred
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612841#action_12612841 ]
Tom White commented on HADOOP-3697:
-----------------------------------
Looking at this again, I can't see the problem that this is trying to solve. org.apache.hadoop.log doesn't depend on org.apache.hadoop.mapred as far as I can see. What am I missing?
> Dependency cycle: log and mapred
> --------------------------------
>
> Key: HADOOP-3697
> URL: https://issues.apache.org/jira/browse/HADOOP-3697
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Bill de hOra
> Priority: Minor
> Attachments: HADOOP-3697.patch
>
>
> There's a dependency cycle between org.apache.hadoop.log and org.apache.hadoop.mapred. Moving the inner servlet class in LogLevel to StatusHttpServer fixes it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3697) Dependency cycle: log and mapred
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-3697:
------------------------------
Status: Patch Available (was: Open)
This looks good to me. Submitting to Hudson.
> Dependency cycle: log and mapred
> --------------------------------
>
> Key: HADOOP-3697
> URL: https://issues.apache.org/jira/browse/HADOOP-3697
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Bill de hOra
> Priority: Minor
> Attachments: HADOOP-3697.patch
>
>
> There's a dependency cycle between org.apache.hadoop.log and org.apache.hadoop.mapred. Moving the inner servlet class in LogLevel to StatusHttpServer fixes it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.