You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/11/27 23:09:04 UTC

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8652


Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................

IMPALA-6241: timeout in admission control test under ASAN

The fix for IMPALA-6241 is to increase the timeout for all slow builds.

While testing that fix, I discovered that the ASAN build detection logic
was failing silently, resulting in it assuming that it was testing a
DEBUG build. The error was:

  Unexpected DW_AT_name in first CU:
  /data/jenkins/workspace/verify-impala-toolchain-package-build/label/ec2-package-ubuntu-16-04/toolchain/source/llvm/llvm-3.9.1.src/projects/compiler-rt/lib/asan/asan_preinit.cc;
  choosing DEBUG

The fix for that issue is to remove the build type detection heuristic
and instead just write a file with the build type as part of the build process.

Testing:
Before this change I was able to reproduce locally every 5-10 test
iterations. After this change I haven't seen it reproduce.

Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
---
M .gitignore
M CMakeLists.txt
M bin/clean-cmake.sh
M infra/python/deps/requirements.txt
M tests/common/environ.py
M tests/custom_cluster/test_admission_controller.py
6 files changed, 54 insertions(+), 140 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/8652/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 01:35:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Michael Brown, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8652

to look at the new patch set (#2).

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................

IMPALA-6241: timeout in admission control test under ASAN

The fix for IMPALA-6241 is to increase the timeout for all slow builds.

While testing that fix, I discovered that the ASAN build detection logic
was failing silently, resulting in it assuming that it was testing a
DEBUG build. The error was:

  Unexpected DW_AT_name in first CU:
  /data/jenkins/workspace/verify-impala-toolchain-package-build/label/ec2-package-ubuntu-16-04/toolchain/source/llvm/llvm-3.9.1.src/projects/compiler-rt/lib/asan/asan_preinit.cc;
  choosing DEBUG

The fix for that issue is to remove the build type detection heuristic
and instead just write a file with the build type as part of the build process.

Testing:
Before this change I was able to reproduce locally every 5-10 test
iterations. After this change I haven't seen it reproduce.

Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
---
M .gitignore
M CMakeLists.txt
M bin/clean-cmake.sh
M infra/python/deps/requirements.txt
M tests/common/environ.py
M tests/custom_cluster/test_admission_controller.py
6 files changed, 61 insertions(+), 143 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/8652/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................


Patch Set 4: Code-Review+2

I discovered that some of the the code I thought was dead was actually imported by another test. Reinstated it.


-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 23:56:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1537/


-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 23:56:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/8652/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8652/1//COMMIT_MSG@10
PS1, Line 10: 
            : While testing that fix, I discovered that the ASAN build detection logic
            : was failing silently
> Sorry to hear this wasn't working. Thanks for making an improvement.
It looks like it was my bug that caused it to fail actually :) (it's unfortunate that the silent nature of the failure caused us to go this long without noticing it though).


http://gerrit.cloudera.org:8080/#/c/8652/1/infra/python/deps/requirements.txt
File infra/python/deps/requirements.txt:

http://gerrit.cloudera.org:8080/#/c/8652/1/infra/python/deps/requirements.txt@45
PS1, Line 45: monkeypatch == 0.1rc3
> I don't think anything else is using this, so it can be removed.
Done


http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@a198
PS1, Line 198: 
> I guess the bug is that this should have been elif.
Oops, that is my bug then - I didn't see this when looking at the code. It doesn't seem like the changed approach really directly addresses the bug then.


http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@19
PS1, Line 19: import pytest
> Unused; remove.
Done


http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@112
PS1, Line 112: is_dev
> Do you want to add ubsan to this method?
Done


http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@122
PS1, Line 122: runs_slowly
> Do you want to add ubsan to this method?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 01:20:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1534/


-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 21:17:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/8652/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8652/1//COMMIT_MSG@10
PS1, Line 10: 
            : While testing that fix, I discovered that the ASAN build detection logic
            : was failing silently
Sorry to hear this wasn't working. Thanks for making an improvement.


http://gerrit.cloudera.org:8080/#/c/8652/1/infra/python/deps/requirements.txt
File infra/python/deps/requirements.txt:

http://gerrit.cloudera.org:8080/#/c/8652/1/infra/python/deps/requirements.txt@45
PS1, Line 45: monkeypatch == 0.1rc3
I don't think anything else is using this, so it can be removed.


http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@19
PS1, Line 19: import pytest
Unused; remove.


http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@112
PS1, Line 112: is_dev
Do you want to add ubsan to this method?


http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@122
PS1, Line 122: runs_slowly
Do you want to add ubsan to this method?



-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 23:46:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1534/


-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 17:41:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................

IMPALA-6241: timeout in admission control test under ASAN

The fix for IMPALA-6241 is to increase the timeout for all slow builds.

While testing that fix, I discovered that the ASAN build detection logic
was failing silently, resulting in it assuming that it was testing a
DEBUG build. The error was:

  Unexpected DW_AT_name in first CU:
  /data/jenkins/workspace/verify-impala-toolchain-package-build/label/ec2-package-ubuntu-16-04/toolchain/source/llvm/llvm-3.9.1.src/projects/compiler-rt/lib/asan/asan_preinit.cc;
  choosing DEBUG

The fix for that issue is to remove the build type detection heuristic
and instead just write a file with the build type as part of the build process.

Testing:
Before this change I was able to reproduce locally every 5-10 test
iterations. After this change I haven't seen it reproduce.

Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Reviewed-on: http://gerrit.cloudera.org:8080/8652
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M .gitignore
M CMakeLists.txt
M bin/clean-cmake.sh
M infra/python/deps/requirements.txt
M tests/common/environ.py
M tests/custom_cluster/test_admission_controller.py
6 files changed, 62 insertions(+), 133 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Michael Brown, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8652

to look at the new patch set (#4).

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................

IMPALA-6241: timeout in admission control test under ASAN

The fix for IMPALA-6241 is to increase the timeout for all slow builds.

While testing that fix, I discovered that the ASAN build detection logic
was failing silently, resulting in it assuming that it was testing a
DEBUG build. The error was:

  Unexpected DW_AT_name in first CU:
  /data/jenkins/workspace/verify-impala-toolchain-package-build/label/ec2-package-ubuntu-16-04/toolchain/source/llvm/llvm-3.9.1.src/projects/compiler-rt/lib/asan/asan_preinit.cc;
  choosing DEBUG

The fix for that issue is to remove the build type detection heuristic
and instead just write a file with the build type as part of the build process.

Testing:
Before this change I was able to reproduce locally every 5-10 test
iterations. After this change I haven't seen it reproduce.

Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
---
M .gitignore
M CMakeLists.txt
M bin/clean-cmake.sh
M infra/python/deps/requirements.txt
M tests/common/environ.py
M tests/custom_cluster/test_admission_controller.py
6 files changed, 62 insertions(+), 133 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/8652/4
-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................


Patch Set 3: Code-Review+2

carry


-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 17:41:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Nov 2017 03:28:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )

Change subject: IMPALA-6241: timeout in admission control test under ASAN
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@a198
PS1, Line 198: 
I guess the bug is that this should have been elif.



-- 
To view, visit http://gerrit.cloudera.org:8080/8652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 00:03:47 +0000
Gerrit-HasComments: Yes