You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/10 15:16:06 UTC
[GitHub] [spark] cloud-fan opened a new pull request #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
cloud-fan opened a new pull request #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
A few improvements to the sql ref SELECT doc:
1. correct the syntax of SELECT query
2. correct the default of null sort order
3. several minor fixes
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
refine document
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
N/A
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597760195
**[Test build #119678 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119678/testReport)** for PR 27866 at commit [`5742080`](https://github.com/apache/spark/commit/57420806b3fb344a816a0ce9a80e5d4800bdd7c9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27866: [SPARK-31110][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597145675
@dilipbiswal @dongjoon-hyun @viirya @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597441472
**[Test build #119646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119646/testReport)** for PR 27866 at commit [`d40afe2`](https://github.com/apache/spark/commit/d40afe2f10434144a993f4240e77c120cadd4ad2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597439379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24377/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r392039338
##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -9,42 +9,43 @@ license: |
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
-The <code>GROUP BY</code> clause is used to group the rows based on a set of specified grouping expressions and compute aggregations on
-the group of rows based on one or more specified aggregate functions. Spark also supports advanced aggregations to do multiple
+The <code>GROUP BY</code> clause is used to group the rows based on a set of specified grouping expressions and compute aggregations on
+the group of rows based on one or more specified aggregate functions. Spark also supports advanced aggregations to do multiple
aggregations for the same input record set via `GROUPING SETS`, `CUBE`, `ROLLUP` clauses.
### Syntax
{% highlight sql %}
-GROUP BY [ GROUPING SETS grouping_sets ] group_expression [ , group_expression [ , ... ] ]
Review comment:
Sorry for late. This change LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597497895
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597767318
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390494821
##########
File path: docs/sql-ref-syntax-qry-select.md
##########
@@ -1,57 +1,61 @@
---
layout: global
title: SELECT
-displayTitle: SELECT
+displayTitle: SELECT
license: |
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
Spark supports a `SELECT` statement and conforms to the ANSI SQL standard. Queries are
-used to retrieve result sets from one or more tables. The following section
+used to retrieve result sets from one or more tables. The following section
describes the overall query syntax and the sub-sections cover different constructs
-of a query along with examples.
+of a query along with examples.
### Syntax
{% highlight sql %}
[ WITH with_query [ , ... ] ]
+select_statement [ { UNION | INTERSECT | EXCEPT } select_statement, ... ]
+[ ORDER BY { expression [ ASC | DESC ] [ NULLS { FIRST | LAST } ] [ , ...] } ]
+[ SORT BY { expression [ ASC | DESC ] [ NULLS { FIRST | LAST } ] [ , ...] } ]
Review comment:
`SORT BY` -> `SORT BY` (double space).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27866: [SPARK-31110][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597144411
**[Test build #119622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119622/testReport)** for PR 27866 at commit [`7ba555e`](https://github.com/apache/spark/commit/7ba555eb94beb69a47781e14690eeaaacae90345).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597145199
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390656694
##########
File path: docs/sql-ref-syntax-qry-select-limit.md
##########
@@ -88,6 +88,11 @@ SELECT name, age FROM person ORDER BY name LIMIT length('SPARK')
| Mike A| 25|
|Shone S| 16|
+-------+---+
+
+-- A non-foldable expression as an input to limit is not allowed.
Review comment:
nit: `limit` -> `LIMIT`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390799225
##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -9,42 +9,43 @@ license: |
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
-The <code>GROUP BY</code> clause is used to group the rows based on a set of specified grouping expressions and compute aggregations on
-the group of rows based on one or more specified aggregate functions. Spark also supports advanced aggregations to do multiple
+The <code>GROUP BY</code> clause is used to group the rows based on a set of specified grouping expressions and compute aggregations on
+the group of rows based on one or more specified aggregate functions. Spark also supports advanced aggregations to do multiple
aggregations for the same input record set via `GROUPING SETS`, `CUBE`, `ROLLUP` clauses.
### Syntax
{% highlight sql %}
-GROUP BY [ GROUPING SETS grouping_sets ] group_expression [ , group_expression [ , ... ] ]
Review comment:
This was wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597497483
**[Test build #119663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119663/testReport)** for PR 27866 at commit [`987034e`](https://github.com/apache/spark/commit/987034e981775994af3efeb374b9b810a27861f2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390669221
##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -44,7 +44,7 @@ GROUP BY [ GROUPING SETS grouping_sets ] group_expression [ , group_expression [
set is specified by a list of comma-separated expressions in parentheses.<br><br>
<b>Syntax:</b>
<code>
- ( () | ( expression [ , ... ] ) )
+ ( '()' | ( expression [ , ... ] ) )
Review comment:
The syntax here indicates one group set or more? In above the syntax is `GROUP BY [ GROUPING SETS grouping_sets ] group_expression [ , group_expression [ , ... ] ]`.
For example, `group_expression` here is for just one group expression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597760904
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24407/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597760890
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597439369
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390392386
##########
File path: docs/sql-ref-syntax-qry-select-clusterby.md
##########
@@ -9,9 +9,9 @@ license: |
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
Review comment:
My editor removes trailing spaces automatically
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597441551
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119646/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390393573
##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -55,25 +55,26 @@ GROUP BY [ GROUPING SETS grouping_sets ] group_expression [ , group_expression [
</dd>
<dt><code><em>ROLLUP</em></code></dt>
<dd>
- Specifies multiple levels of aggregations in a single statement. This clause is used to compute aggregations
- based on multiple grouping sets. <code>ROLLUP</code> is shorthand for <code>GROUPING SETS</code>. For example,
- GROUP BY warehouse, product WITH ROLLUP is equivalent to GROUP BY <code>warehouse, product</code> GROUPING SETS
- <code> ((warehouse, product), (warehouse), ())</code>.
+ Specifies multiple levels of aggregations in a single statement. This clause is used to compute aggregations
+ based on multiple grouping sets. <code>ROLLUP</code> is a shorthand for <code>GROUPING SETS</code>. For example,
+ <code>GROUP BY warehouse, product WITH ROLLUP</code> is equivalent to <code>GROUP BY GROUPING SETS
Review comment:
GROUP BY GROUPING SETS ... is the same as GROUP BY a, b GROUPING SETS but shorter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597502770
**[Test build #119663 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119663/testReport)** for PR 27866 at commit [`987034e`](https://github.com/apache/spark/commit/987034e981775994af3efeb374b9b810a27861f2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866: [SPARK-31110][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597150289
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119622/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597497483
**[Test build #119663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119663/testReport)** for PR 27866 at commit [`987034e`](https://github.com/apache/spark/commit/987034e981775994af3efeb374b9b810a27861f2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597439379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24377/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866: [SPARK-31110][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597145209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24351/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597502936
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597760195
**[Test build #119678 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119678/testReport)** for PR 27866 at commit [`5742080`](https://github.com/apache/spark/commit/57420806b3fb344a816a0ce9a80e5d4800bdd7c9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597760890
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597497902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24394/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597441544
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597441544
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390395437
##########
File path: docs/sql-ref-syntax-qry-select.md
##########
@@ -1,57 +1,61 @@
---
layout: global
title: SELECT
-displayTitle: SELECT
+displayTitle: SELECT
license: |
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
Spark supports a `SELECT` statement and conforms to the ANSI SQL standard. Queries are
-used to retrieve result sets from one or more tables. The following section
+used to retrieve result sets from one or more tables. The following section
describes the overall query syntax and the sub-sections cover different constructs
-of a query along with examples.
+of a query along with examples.
### Syntax
{% highlight sql %}
[ WITH with_query [ , ... ] ]
+select_statement [ { UNION | INTERSECT | EXCEPT } select_statement, ... ]
+[ ORDER BY { expression [ ASC | DESC ] [ NULLS { FIRST | LAST } ] [ , ...] } ]
Review comment:
according to our g4 file, a query can have multiple SELECT but only one ORDER BY/SORT BY/...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r392039338
##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -9,42 +9,43 @@ license: |
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
-The <code>GROUP BY</code> clause is used to group the rows based on a set of specified grouping expressions and compute aggregations on
-the group of rows based on one or more specified aggregate functions. Spark also supports advanced aggregations to do multiple
+The <code>GROUP BY</code> clause is used to group the rows based on a set of specified grouping expressions and compute aggregations on
+the group of rows based on one or more specified aggregate functions. Spark also supports advanced aggregations to do multiple
aggregations for the same input record set via `GROUPING SETS`, `CUBE`, `ROLLUP` clauses.
### Syntax
{% highlight sql %}
-GROUP BY [ GROUPING SETS grouping_sets ] group_expression [ , group_expression [ , ... ] ]
Review comment:
Sorry for late. This LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597144411
**[Test build #119622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119622/testReport)** for PR 27866 at commit [`7ba555e`](https://github.com/apache/spark/commit/7ba555eb94beb69a47781e14690eeaaacae90345).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597760904
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24407/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597497895
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390494429
##########
File path: docs/sql-ref-syntax-qry-select.md
##########
@@ -1,57 +1,61 @@
---
layout: global
title: SELECT
-displayTitle: SELECT
+displayTitle: SELECT
license: |
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
Spark supports a `SELECT` statement and conforms to the ANSI SQL standard. Queries are
-used to retrieve result sets from one or more tables. The following section
+used to retrieve result sets from one or more tables. The following section
describes the overall query syntax and the sub-sections cover different constructs
-of a query along with examples.
+of a query along with examples.
### Syntax
{% highlight sql %}
[ WITH with_query [ , ... ] ]
+select_statement [ { UNION | INTERSECT | EXCEPT } select_statement, ... ]
Review comment:
`[ ALL | DISTINCT ]` seems to be missed while transition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597439369
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390394463
##########
File path: docs/sql-ref-syntax-qry-select-orderby.md
##########
@@ -47,20 +47,18 @@ ORDER BY { expression [ sort_direction | nulls_sort_oder ] [ , ... ] }
</dd>
<dt><code><em>nulls_sort_order</em></code></dt>
<dd>
- Optionally specifies whether NULL values are returned before/after non-NULL values, based on the
- sort direction. In Spark, NULL values are considered to be lower than any non-NULL values by default.
- Therefore the ordering of NULL values depend on the sort direction. If <code>null_sort_order</code> is
- not specified, then NULLs sort first if sort order is <code>ASC</code> and NULLS sort last if
- sort order is <code>DESC</code>.<br><br>
+ Optionally specifies whether NULL values are returned before/after non-NULL values. If
+ <code>null_sort_order</code> is not specified, then NULLs sort first if sort order is
+ <code>ASC</code> and NULLS sort last if sort order is <code>DESC</code>.<br><br>
Review comment:
We don't need to mention `In Spark, NULL values are considered to be lower than any non-NULL values`, as it's not related to the user-facing behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597150289
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119622/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597502936
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27866: [SPARK-31110][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597150133
**[Test build #119622 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119622/testReport)** for PR 27866 at commit [`7ba555e`](https://github.com/apache/spark/commit/7ba555eb94beb69a47781e14690eeaaacae90345).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r391115170
##########
File path: docs/sql-ref-syntax-qry-select.md
##########
@@ -1,57 +1,61 @@
---
layout: global
title: SELECT
-displayTitle: SELECT
+displayTitle: SELECT
license: |
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
Spark supports a `SELECT` statement and conforms to the ANSI SQL standard. Queries are
-used to retrieve result sets from one or more tables. The following section
+used to retrieve result sets from one or more tables. The following section
describes the overall query syntax and the sub-sections cover different constructs
-of a query along with examples.
+of a query along with examples.
### Syntax
{% highlight sql %}
[ WITH with_query [ , ... ] ]
+select_statement [ { UNION | INTERSECT | EXCEPT } select_statement, ... ]
Review comment:
Hi, @cloud-fan . They are not the same. I mean `UNION ALL`, not `SELECT ALL`.
```
scala> sql("select 1 union all (select all 1)").show
+---+
| 1|
+---+
| 1|
| 1|
+---+
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597145209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24351/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597439142
**[Test build #119646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119646/testReport)** for PR 27866 at commit [`d40afe2`](https://github.com/apache/spark/commit/d40afe2f10434144a993f4240e77c120cadd4ad2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390494821
##########
File path: docs/sql-ref-syntax-qry-select.md
##########
@@ -1,57 +1,61 @@
---
layout: global
title: SELECT
-displayTitle: SELECT
+displayTitle: SELECT
license: |
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
Spark supports a `SELECT` statement and conforms to the ANSI SQL standard. Queries are
-used to retrieve result sets from one or more tables. The following section
+used to retrieve result sets from one or more tables. The following section
describes the overall query syntax and the sub-sections cover different constructs
-of a query along with examples.
+of a query along with examples.
### Syntax
{% highlight sql %}
[ WITH with_query [ , ... ] ]
+select_statement [ { UNION | INTERSECT | EXCEPT } select_statement, ... ]
+[ ORDER BY { expression [ ASC | DESC ] [ NULLS { FIRST | LAST } ] [ , ...] } ]
+[ SORT BY { expression [ ASC | DESC ] [ NULLS { FIRST | LAST } ] [ , ...] } ]
Review comment:
```
- SORT BY
+ SORT BY
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597767326
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119678/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597767326
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119678/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390739939
##########
File path: docs/sql-ref-syntax-qry-select.md
##########
@@ -1,57 +1,61 @@
---
layout: global
title: SELECT
-displayTitle: SELECT
+displayTitle: SELECT
license: |
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
Spark supports a `SELECT` statement and conforms to the ANSI SQL standard. Queries are
-used to retrieve result sets from one or more tables. The following section
+used to retrieve result sets from one or more tables. The following section
describes the overall query syntax and the sub-sections cover different constructs
-of a query along with examples.
+of a query along with examples.
### Syntax
{% highlight sql %}
[ WITH with_query [ , ... ] ]
+select_statement [ { UNION | INTERSECT | EXCEPT } select_statement, ... ]
Review comment:
It's defined in `select_statement`: https://github.com/apache/spark/pull/27866/files#diff-bc52347d9c1373190bce4389d3066ad5R40
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597497902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24394/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597441551
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119646/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597767130
**[Test build #119678 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119678/testReport)** for PR 27866 at commit [`5742080`](https://github.com/apache/spark/commit/57420806b3fb344a816a0ce9a80e5d4800bdd7c9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597745771
@cloud-fan . Please don't forget the following
- https://github.com/apache/spark/pull/27866#discussion_r391115170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390799490
##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -9,42 +9,43 @@ license: |
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
-The <code>GROUP BY</code> clause is used to group the rows based on a set of specified grouping expressions and compute aggregations on
-the group of rows based on one or more specified aggregate functions. Spark also supports advanced aggregations to do multiple
+The <code>GROUP BY</code> clause is used to group the rows based on a set of specified grouping expressions and compute aggregations on
+the group of rows based on one or more specified aggregate functions. Spark also supports advanced aggregations to do multiple
aggregations for the same input record set via `GROUPING SETS`, `CUBE`, `ROLLUP` clauses.
### Syntax
{% highlight sql %}
-GROUP BY [ GROUPING SETS grouping_sets ] group_expression [ , group_expression [ , ... ] ]
Review comment:
@viirya can you help review this file? thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597502944
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119663/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390392664
##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -9,33 +9,33 @@ license: |
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
---
-The <code>GROUP BY</code> clause is used to group the rows based on a set of specified grouping expressions and compute aggregations on
-the group of rows based on one or more specified aggregate functions. Spark also supports advanced aggregations to do multiple
+The <code>GROUP BY</code> clause is used to group the rows based on a set of specified grouping expressions and compute aggregations on
+the group of rows based on one or more specified aggregate functions. Spark also supports advanced aggregations to do multiple
aggregations for the same input record set via `GROUPING SETS`, `CUBE`, `ROLLUP` clauses.
### Syntax
{% highlight sql %}
GROUP BY [ GROUPING SETS grouping_sets ] group_expression [ , group_expression [ , ... ] ]
- [ ( WITH ROLLUP | WITH CUBE | GROUPING SETS grouping_sets ) ) ]
+ [ ( WITH ROLLUP | WITH CUBE | GROUPING SETS grouping_sets ) ]
Review comment:
remove the extra `)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597150281
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27866:
[SPARK-31110][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#discussion_r390394681
##########
File path: docs/sql-ref-syntax-qry-select-orderby.md
##########
@@ -47,20 +47,18 @@ ORDER BY { expression [ sort_direction | nulls_sort_oder ] [ , ... ] }
</dd>
<dt><code><em>nulls_sort_order</em></code></dt>
<dd>
- Optionally specifies whether NULL values are returned before/after non-NULL values, based on the
- sort direction. In Spark, NULL values are considered to be lower than any non-NULL values by default.
- Therefore the ordering of NULL values depend on the sort direction. If <code>null_sort_order</code> is
- not specified, then NULLs sort first if sort order is <code>ASC</code> and NULLS sort last if
- sort order is <code>DESC</code>.<br><br>
+ Optionally specifies whether NULL values are returned before/after non-NULL values. If
+ <code>null_sort_order</code> is not specified, then NULLs sort first if sort order is
+ <code>ASC</code> and NULLS sort last if sort order is <code>DESC</code>.<br><br>
<ol>
- <li> If <code>NULLS FIRST</code> (the default) is specified, then NULL values are returned first
+ <li> If <code>NULLS FIRST</code> is specified, then NULL values are returned first
Review comment:
the default value depends on the sort order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597439142
**[Test build #119646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119646/testReport)** for PR 27866 at commit [`d40afe2`](https://github.com/apache/spark/commit/d40afe2f10434144a993f4240e77c120cadd4ad2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866: [SPARK-31110][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597145199
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597502944
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119663/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866: [SPARK-31110][SQL]
refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597150281
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866#issuecomment-597767318
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27866:
[SPARK-31110][DOCS][SQL] refine sql doc for SELECT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27866: [SPARK-31110][DOCS][SQL] refine sql doc for SELECT
URL: https://github.com/apache/spark/pull/27866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org